> On Aug. 26, 2015, 4:35 p.m., Jarek Cecho wrote: > > Thanks for the patch Dian! Couple of high level points: > > > > 1) Can we add tests for the new functionality?
Thanks Jarcec for the review. Updated the patch to add new tests and address the code review comments. - Dian ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37793/#review96542 ----------------------------------------------------------- On Aug. 26, 2015, 9:30 a.m., Dian Fu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/37793/ > ----------------------------------------------------------- > > (Updated Aug. 26, 2015, 9:30 a.m.) > > > Review request for Sqoop. > > > Bugs: SQOOP-2530 > https://issues.apache.org/jira/browse/SQOOP-2530 > > > Repository: sqoop-sqoop2 > > > Description > ------- > > We need add some utility methods to translate connectorId/linkId/jobId to the > corresponding connectorName/linkName/jobName. > > > Diffs > ----- > > common/src/main/java/org/apache/sqoop/error/code/CommonRepositoryError.java > 9f4a0f8 > core/src/main/java/org/apache/sqoop/repository/JdbcRepository.java 9a4853b > core/src/main/java/org/apache/sqoop/repository/JdbcRepositoryHandler.java > f690887 > core/src/main/java/org/apache/sqoop/repository/Repository.java 610876c > > repository/repository-common/src/main/java/org/apache/sqoop/repository/common/CommonRepositoryHandler.java > af9324f > > repository/repository-common/src/main/java/org/apache/sqoop/repository/common/CommonRepositoryInsertUpdateDeleteSelectQuery.java > 4f9e547 > server/src/main/java/org/apache/sqoop/handler/HandlerUtils.java 5fcde52 > server/src/main/java/org/apache/sqoop/server/common/ServerError.java > c68ab57 > > Diff: https://reviews.apache.org/r/37793/diff/ > > > Testing > ------- > > > Thanks, > > Dian Fu > >
