----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37868/#review96846 -----------------------------------------------------------
Generally it looks fine, I have one nit below and then it seems that precommit hook is complaining about failing integration tests. security/src/main/java/org/apache/sqoop/security/authorization/AuthorizationEngine.java (lines 39 - 49) <https://reviews.apache.org/r/37868/#comment152529> Nit: Do we need the interim variables here? Can we just do: case CONNECTOR: return repository.findConnector(id).getUniqueName(); case LINK: ... Jarcec - Jarek Cecho On Aug. 28, 2015, 2:47 a.m., Dian Fu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/37868/ > ----------------------------------------------------------- > > (Updated Aug. 28, 2015, 2:47 a.m.) > > > Review request for Sqoop. > > > Bugs: SQOOP-2537 > https://issues.apache.org/jira/browse/SQOOP-2537 > > > Repository: sqoop-sqoop2 > > > Description > ------- > > Currently the meaning of the name field in MResource isn't consistent. Some > places assume this field means the object name of the resource, such as in > AuthorizationRequestHandler. Some places assume this field means the object > id of the resource, such as in AuthorizationEngine. > > > Diffs > ----- > > > security/src/main/java/org/apache/sqoop/security/authorization/AuthorizationEngine.java > bebbe91 > server/src/main/java/org/apache/sqoop/handler/ConnectorRequestHandler.java > 23f6c63 > server/src/main/java/org/apache/sqoop/handler/JobRequestHandler.java > 13ebb35 > server/src/main/java/org/apache/sqoop/handler/LinkRequestHandler.java > aa7e5ff > server/src/main/java/org/apache/sqoop/handler/SubmissionRequestHandler.java > f2a6758 > > Diff: https://reviews.apache.org/r/37868/diff/ > > > Testing > ------- > > > Thanks, > > Dian Fu > >
