> On Sept. 8, 2015, 5:39 a.m., Dian Fu wrote:
> > test/src/test/java/org/apache/sqoop/integration/server/InvalidRESTCallsTest.java,
> >  line 148
> > <https://reviews.apache.org/r/37923/diff/1/?file=1059362#file1059362line148>
> >
> >     Patch ofSQOOP-2544 has removed the check of the request method. So 
> > either we need refine the patch of SQOOP-2544 to revert that modification 
> > or we need modify patch here.

I believe taht SQOOP-2544 is removing just the "/connectors" end point whereas 
this patch is adding tests only for "/connector", right? (E.g. the SQOOP-2544 
is dropping support for the end point with "plurar" form whereas this patch 
uses only the end point in "singular" that has been unchanged)


- Jarek


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37923/#review97967
-----------------------------------------------------------


On Aug. 29, 2015, 1:46 p.m., Jarek Cecho wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37923/
> -----------------------------------------------------------
> 
> (Updated Aug. 29, 2015, 1:46 p.m.)
> 
> 
> Review request for Sqoop.
> 
> 
> Bugs: SQOOP-2547
>     https://issues.apache.org/jira/browse/SQOOP-2547
> 
> 
> Repository: sqoop-sqoop2
> 
> 
> Description
> -------
> 
> Provided additional tests...
> 
> 
> Diffs
> -----
> 
>   
> test/src/test/java/org/apache/sqoop/integration/server/InvalidRESTCallsTest.java
>  da3a6ea 
> 
> Diff: https://reviews.apache.org/r/37923/diff/
> 
> 
> Testing
> -------
> 
> ...that are passing!
> 
> 
> Thanks,
> 
> Jarek Cecho
> 
>

Reply via email to