----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38670/#review100461 -----------------------------------------------------------
Overall the code looks good to me, but I have few questions: 1) Since this is significant change, we should provide some tests for it. I'm not immediately sure how to test those though. Any thoughts Dian? 2) I was wondering what are we gainging by caching the loaded classes? Is it faster then without the caching? 3) I didn't fully understood the need for NEGATIVE_CACHE_SENTINEL - can't be "null" used instead of it? Jarcec - Jarek Cecho On Sept. 24, 2015, 1:17 a.m., Dian Fu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/38670/ > ----------------------------------------------------------- > > (Updated Sept. 24, 2015, 1:17 a.m.) > > > Review request for Sqoop. > > > Bugs: SQOOP-2577 > https://issues.apache.org/jira/browse/SQOOP-2577 > > > Repository: sqoop-sqoop2 > > > Description > ------- > > Currently, ClassUtils doesn't support to load classes using a custom > classloader. The aim of this JIRA is to provide ClassUtils with this capacity. > > > Diffs > ----- > > common/src/main/java/org/apache/sqoop/utils/ClassUtils.java 6262802 > > Diff: https://reviews.apache.org/r/38670/diff/ > > > Testing > ------- > > > Thanks, > > Dian Fu > >
