----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37249/#review100825 -----------------------------------------------------------
Ship it! Ship It! - Jarek Cecho On Sept. 16, 2015, 11:42 p.m., Venkat Ranganathan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/37249/ > ----------------------------------------------------------- > > (Updated Sept. 16, 2015, 11:42 p.m.) > > > Review request for Sqoop and Jarek Cecho. > > > Bugs: SQOOP-2387 > https://issues.apache.org/jira/browse/SQOOP-2387 > > > Repository: sqoop-trunk > > > Description > ------- > > Added support for non identifier characters to be used in sqoop imports with > HCatalog, Parquet and Avro imports > > > Diffs > ----- > > build.xml 7bc6a5b > src/docs/user/import.txt 342633a > src/java/org/apache/sqoop/avro/AvroUtil.java 9036076 > src/java/org/apache/sqoop/manager/HsqldbManager.java fefac3f > src/java/org/apache/sqoop/mapreduce/hcat/SqoopHCatImportHelper.java 878f765 > src/java/org/apache/sqoop/mapreduce/hcat/SqoopHCatUtilities.java 4070c24 > src/java/org/apache/sqoop/orm/ClassWriter.java 1c6f7f4 > src/test/com/cloudera/sqoop/TestAvroImport.java 260e80a > src/test/com/cloudera/sqoop/TestIncrementalImport.java a6680e8 > src/test/com/cloudera/sqoop/TestParquetImport.java ae2e617 > src/test/com/cloudera/sqoop/testutil/BaseSqoopTestCase.java e3098d6 > src/test/org/apache/sqoop/hcat/HCatalogImportTest.java d97b870 > src/test/org/apache/sqoop/hcat/HCatalogTestUtils.java 32c267f > > Diff: https://reviews.apache.org/r/37249/diff/ > > > Testing > ------- > > Added more tests for these scenarios and all tests pass. Also updated the > test infrastructure to handle columns with non-identifier characters > > > Thanks, > > Venkat Ranganathan > >
