----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37353/#review100838 -----------------------------------------------------------
Thanks for taking a look Shashank and my apologies for late review on this one. Would you mind adding tests for the newly added functionality? src/java/org/apache/sqoop/mapreduce/hcat/SqoopHCatUtilities.java (lines 843 - 845) <https://reviews.apache.org/r/37353/#comment158092> Can we also add similar case for parquet? src/java/org/apache/sqoop/mapreduce/hcat/SqoopHCatUtilities.java (lines 845 - 849) <https://reviews.apache.org/r/37353/#comment158089> Shouldn't the FileOutputFormat be wrapped in else statement? src/java/org/apache/sqoop/tool/ImportTool.java (lines 1152 - 1159) <https://reviews.apache.org/r/37353/#comment158091> I'm wondering if this is indeed that case - the code seems to be allowin any codec for text file and only limiting snappy for sequencefile/orc. Jarcec - Jarek Cecho On Aug. 11, 2015, 10:39 a.m., Shashank Tandon wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/37353/ > ----------------------------------------------------------- > > (Updated Aug. 11, 2015, 10:39 a.m.) > > > Review request for Sqoop and Venkat Ranganathan. > > > Repository: sqoop-trunk > > > Description > ------- > > Apache Sqoop does not compress with --compress option with > --hcatalog-table.It also does not support option --compression-codec snappy. > Will add Snappy compression support in Apache Sqoop. When a user will try to > use --compress, then it will use the by default compression i.e. GZIP. > otherwise If user provide option --compress --compression-codec snappy then > it will compress into snappy format. > > > Diffs > ----- > > src/docs/user/hcatalog.txt 99ae4f5 > src/java/org/apache/sqoop/config/ConfigurationConstants.java e19c17b > src/java/org/apache/sqoop/io/CodecMap.java cec9358 > src/java/org/apache/sqoop/mapreduce/hcat/SqoopHCatUtilities.java 4070c24 > src/java/org/apache/sqoop/tool/ImportTool.java 39af42c > > Diff: https://reviews.apache.org/r/37353/diff/ > > > Testing > ------- > > yes > > > Thanks, > > Shashank Tandon > >
