----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39512/#review103584 -----------------------------------------------------------
repository/repository-mysql/pom.xml (lines 82 - 87) <https://reviews.apache.org/r/39512/#comment161660> Commenting code is not something that we can easily do from Jenkins (it requires human being). I'm wondering why is this code not working? We have similar idiom in PostgreSQL repository and it's working just fine: https://github.com/apache/sqoop/blob/sqoop2/repository/repository-postgresql/pom.xml#L75 It runs the postgresql tests only if you run with -Ppostgresql - a special maven profile. Perhaps we should take a look why is MySQL different and fix that rather then making MySQL tests behave differently? repository/repository-mysql/src/test/resources/repo-mysql-tests-suite.xml (lines 1 - 30) <https://reviews.apache.org/r/39512/#comment161777> What is the value of using the custom suite instead of the standard one? I would prefer to keep the standard one unless there is a compelling reason not to. For example, in the test/ module the compelling reason is to not start the Hadoop Mini cluster for every class. - Jarek Cecho On Oct. 22, 2015, 7:47 a.m., Colin Ma wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39512/ > ----------------------------------------------------------- > > (Updated Oct. 22, 2015, 7:47 a.m.) > > > Review request for Sqoop. > > > Repository: sqoop-sqoop2 > > > Description > ------- > > The unit test for MySql repository should be enable when do the pre-commit. > Add embed MySql server with mysql-connector-mxj. > > > Diffs > ----- > > > common-test/src/main/java/org/apache/sqoop/common/test/db/MySQLProvider.java > cef59bb > > common-test/src/main/java/org/apache/sqoop/common/test/testng/SqoopTestListener.java > PRE-CREATION > repository/repository-mysql/pom.xml 15e909e > > repository/repository-mysql/src/test/java/org/apache/sqoop/integration/repository/mysql/MySqlTestCase.java > fcd4b71 > repository/repository-mysql/src/test/resources/repo-mysql-tests-suite.xml > PRE-CREATION > test/src/main/java/org/apache/sqoop/test/testng/SqoopTestListener.java > b9c1406 > test/src/test/resources/classpath-tests-suite.xml e5a9e94 > test/src/test/resources/integration-tests-suite.xml 1cf3299 > test/src/test/resources/new-integration-tests-suite.xml 8206e52 > test/src/test/resources/upgrade-tests-suite.xml 3318e67 > > Diff: https://reviews.apache.org/r/39512/diff/ > > > Testing > ------- > > > Thanks, > > Colin Ma > >
