> On Nov. 30, 2015, 6:50 p.m., Abraham Fine wrote: > > docs/src/site/sphinx/admin/Installation.rst, line 69 > > <https://reviews.apache.org/r/40576/diff/2/?file=1147100#file1147100line69> > > > > "Sqoop server requires further configuration on Hadoop side" is not > > needed. > > > > I would split this section into two subsections: "HDFS Proxy Users" and > > "YARN Whitelist".
I've nuked the introduction sentence - I already do have two logical sections for Proxy/Whitelist already. I didn't want to introduce yet another nested structure though so I have it under one "headline". > On Nov. 30, 2015, 6:50 p.m., Abraham Fine wrote: > > docs/src/site/sphinx/admin/Installation.rst, line 71 > > <https://reviews.apache.org/r/40576/diff/2/?file=1147100#file1147100line71> > > > > does this always need to be enabled. could there be use cases (such as > > moving data for s3 to an rdbms) where the cluster does not need to be > > configured to allow impersonation? The reality is that only if you're using HDFS connector this will be needed. But as that is so common use case, I did not wanted to burry that inside the HDFS connector docs but rather expose it here in the installation docs. > On Nov. 30, 2015, 6:50 p.m., Abraham Fine wrote: > > docs/src/site/sphinx/admin/Installation.rst, line 97 > > <https://reviews.apache.org/r/40576/diff/2/?file=1147100#file1147100line97> > > > > I would describe the use case here in a little bit more detail. We have > > a few different ways of loading jars into sqoop 2. Perhaps we should move > > this out of the installation documentation into its own page to keep > > initial installation simple. True, we also have ability to configure jars in jobs and such. Would you mind if I'll keep it this way for now and add a standalone section about classpath later? (especially after Dian will be done with connector classpath isolation project). > On Nov. 30, 2015, 6:50 p.m., Abraham Fine wrote: > > docs/src/site/sphinx/admin/Tools.rst, line 60 > > <https://reviews.apache.org/r/40576/diff/2/?file=1147101#file1147101line60> > > > > "the same file" Let's fix the Tools documentation separately - I'm editing the file only to add anchors at this point. > On Nov. 30, 2015, 6:50 p.m., Abraham Fine wrote: > > docs/src/site/sphinx/admin/Tools.rst, line 67 > > <https://reviews.apache.org/r/40576/diff/2/?file=1147101#file1147101line67> > > > > Perhaps we should make it clear that we are not actually downloading > > and installing a new version of sqoop 2 as a side node? > > > > Really this is a "repository upgrade tool". Let's fix the Tools documentation separately - I'm editing the file only to add anchors at this point. - Jarek ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40576/#review108352 ----------------------------------------------------------- On Nov. 25, 2015, 7:40 p.m., Jarek Cecho wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/40576/ > ----------------------------------------------------------- > > (Updated Nov. 25, 2015, 7:40 p.m.) > > > Review request for Sqoop. > > > Bugs: SQOOP-2708 > https://issues.apache.org/jira/browse/SQOOP-2708 > > > Repository: sqoop-sqoop2 > > > Description > ------- > > I've updated the installation guide and incoporated changes that were missing. > > > Diffs > ----- > > docs/src/site/sphinx/admin/Installation.rst 9d56875 > docs/src/site/sphinx/admin/Tools.rst fb0187a > > Diff: https://reviews.apache.org/r/40576/diff/ > > > Testing > ------- > > > Thanks, > > Jarek Cecho > >
