> On Dec. 10, 2015, 9:45 p.m., Jarek Cecho wrote: > > connector/connector-generic-jdbc/src/test/java/org/apache/sqoop/connector/jdbc/TestPartitioner.java, > > line 261 > > <https://reviews.apache.org/r/40896/diff/10/?file=1159047#file1159047line261> > > > > Would you mind describing what exactly is going wrong with the original > > implementation? I'm failing to see the bug sadly.
What happens if the number of splits, determined by the splitSize (BigDecimal splitSize = divide(maxValue.subtract(minValue), new BigDecimal(numberPartitions));) is greater than the numberPartitions? Consider the example from the test. partitionMinValue = 1, partitionMaxValue = 13, and numberPartitions = 11 We end up calculating a splitSize of 1. which gives us splitPoints [1, 2, 3, ..., 13] We end up creating 13 splits, rather than just 11 (as we generate one split for each splitPoint). - Abraham ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40896/#review109853 ----------------------------------------------------------- On Dec. 15, 2015, 12:05 a.m., Abraham Fine wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/40896/ > ----------------------------------------------------------- > > (Updated Dec. 15, 2015, 12:05 a.m.) > > > Review request for Sqoop. > > > Bugs: SQOOP-2719 > https://issues.apache.org/jira/browse/SQOOP-2719 > > > Repository: sqoop-sqoop2 > > > Description > ------- > > Sqoop2: Ensure the GenericJDBCConnector integration tests work against MySQL, > PostgreSQL, and Oracle > > > Diffs > ----- > > > common-test/src/main/java/org/apache/sqoop/common/test/asserts/ProviderAsserts.java > 0da7ea8 > > common-test/src/main/java/org/apache/sqoop/common/test/db/DatabaseProvider.java > f30d587 > > common-test/src/main/java/org/apache/sqoop/common/test/db/MySQLProvider.java > 393904f > > connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcExecutor.java > ff33a4b > > connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcExtractor.java > edb2754 > > connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcFromInitializer.java > fa26c14 > > connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcPartition.java > 65400ef > > connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcPartitioner.java > 2a42ed4 > > connector/connector-generic-jdbc/src/test/java/org/apache/sqoop/connector/jdbc/TestExtractor.java > 3b52128 > > connector/connector-generic-jdbc/src/test/java/org/apache/sqoop/connector/jdbc/TestGenericJdbcPartition.java > PRE-CREATION > > connector/connector-generic-jdbc/src/test/java/org/apache/sqoop/connector/jdbc/TestPartitioner.java > 3a767ab > test/src/main/java/org/apache/sqoop/test/data/Cities.java fbbd7ef > test/src/main/java/org/apache/sqoop/test/data/UbuntuReleases.java 12bcad1 > test/src/main/java/org/apache/sqoop/test/infrastructure/SqoopTestCase.java > c1f355f > test/src/main/java/org/apache/sqoop/test/testcases/ConnectorTestCase.java > c843448 > > test/src/test/java/org/apache/sqoop/integration/connector/hdfs/AppendModeTest.java > 8c65898 > > test/src/test/java/org/apache/sqoop/integration/connector/hdfs/FromHDFSToHDFSTest.java > c39c8d6 > > test/src/test/java/org/apache/sqoop/integration/connector/hdfs/HdfsIncrementalReadTest.java > e6f6e0d > > test/src/test/java/org/apache/sqoop/integration/connector/hdfs/InformalJobNameExecuteTest.java > 411b07e > > test/src/test/java/org/apache/sqoop/integration/connector/hdfs/OutputDirectoryTest.java > 1790f96 > > test/src/test/java/org/apache/sqoop/integration/connector/jdbc/generic/AllTypesTest.java > 5053b56 > > test/src/test/java/org/apache/sqoop/integration/connector/jdbc/generic/FromHDFSToRDBMSTest.java > 25cdb68 > > test/src/test/java/org/apache/sqoop/integration/connector/jdbc/generic/FromRDBMSToHDFSTest.java > 686572a > > test/src/test/java/org/apache/sqoop/integration/connector/jdbc/generic/IncrementalReadTest.java > f850768 > > test/src/test/java/org/apache/sqoop/integration/connector/jdbc/generic/PartitionerTest.java > 42bff65 > > test/src/test/java/org/apache/sqoop/integration/connector/jdbc/generic/TableStagedRDBMSTest.java > 68dc65e > > test/src/test/java/org/apache/sqoop/integration/connector/kafka/FromRDBMSToKafkaTest.java > 4ecb018 > > Diff: https://reviews.apache.org/r/40896/diff/ > > > Testing > ------- > > yes > > > Thanks, > > Abraham Fine > >
