----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41335/#review110490 -----------------------------------------------------------
Nice, I have only one question/comment: common/src/main/java/org/apache/sqoop/json/SubmissionBean.java (lines 107 - 183) <https://reviews.apache.org/r/41335/#comment170411> I'm wondering if we really need to set the job name twice? I'm assuming that we were doing that to preserve backward compatibilty in the past. As the upcoming 1.99.7 has broke the protokol already so much (and will broke it even more in near future), I would recommnd to drop one of the keys and use single one. Jarcec - Jarek Cecho On Dec. 14, 2015, 6:11 a.m., Colin Ma wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/41335/ > ----------------------------------------------------------- > > (Updated Dec. 14, 2015, 6:11 a.m.) > > > Review request for Sqoop. > > > Repository: sqoop-sqoop2 > > > Description > ------- > > Use job name in MSubmission > > > Diffs > ----- > > common/src/main/java/org/apache/sqoop/json/SubmissionBean.java e6b300d > common/src/main/java/org/apache/sqoop/model/MSubmission.java 11110ae > common/src/test/java/org/apache/sqoop/json/TestSubmissionBean.java 1fc2ae2 > core/src/main/java/org/apache/sqoop/driver/JobManager.java 4f4b9d3 > core/src/test/java/org/apache/sqoop/driver/TestJobManager.java 8da759e > > repository/repository-common/src/main/java/org/apache/sqoop/repository/common/CommonRepositoryHandler.java > 13d8242 > > repository/repository-common/src/main/java/org/apache/sqoop/repository/common/CommonRepositoryInsertUpdateDeleteSelectQuery.java > fa5a1c1 > > repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestSubmissionHandling.java > 621d4e1 > > repository/repository-mysql/src/test/java/org/apache/sqoop/integration/repository/mysql/MySqlTestCase.java > ede930f > > repository/repository-mysql/src/test/java/org/apache/sqoop/integration/repository/mysql/TestSubmissionHandling.java > b4f34b6 > > repository/repository-postgresql/src/test/java/org/apache/sqoop/integration/repository/postgresql/PostgresqlTestCase.java > 1bab548 > > repository/repository-postgresql/src/test/java/org/apache/sqoop/integration/repository/postgresql/TestSubmissionHandling.java > cd3367e > > security/src/main/java/org/apache/sqoop/security/authorization/AuthorizationEngine.java > e7b7dac > server/src/main/java/org/apache/sqoop/handler/JobRequestHandler.java > c70f457 > shell/src/main/java/org/apache/sqoop/shell/ShowSubmissionFunction.java > 45f3bdd > shell/src/main/java/org/apache/sqoop/shell/core/Constants.java 9e2b3e2 > shell/src/main/java/org/apache/sqoop/shell/utils/SubmissionDisplayer.java > 3a78371 > shell/src/main/resources/shell-resource.properties 0ff853f > shell/src/test/java/org/apache/sqoop/shell/TestShowCommand.java 05b4e52 > > Diff: https://reviews.apache.org/r/41335/diff/ > > > Testing > ------- > > > Thanks, > > Colin Ma > >
