> On Dec. 15, 2015, 2:01 p.m., Jarek Cecho wrote: > > Thanks for bearing with me on the reviews Dian, few last comments:
Thanks a lot for the review Jarcec. It's very helpful. :) > On Dec. 15, 2015, 2:01 p.m., Jarek Cecho wrote: > > test/src/main/java/org/apache/sqoop/test/infrastructure/SqoopTestCase.java, > > line 168 > > <https://reviews.apache.org/r/40635/diff/14/?file=1162143#file1162143line168> > > > > Why do we need to remove the infrastructure provider here from the > > "providers"? Shouldn't we keep it there so that we properly call "close" on > > the provider? providers is just a local variable and so it will not affect the "close" of the providers. Moreover, if we don't remove the providers which are already started such as KdcInfrastructureProvider, it will be started again in the process of "Start the rest of the providers." > On Dec. 15, 2015, 2:01 p.m., Jarek Cecho wrote: > > test/src/main/java/org/apache/sqoop/test/infrastructure/SqoopTestCase.java, > > line 179 > > <https://reviews.apache.org/r/40635/diff/14/?file=1162143#file1162143line179> > > > > Why do we need to remove the infrastructure provider here from the > > "providers"? Shouldn't we keep it there so that we properly call "close" on > > the provider? providers is just a local variable and so it will not affect the "close" of the providers. Moreover, if we don't remove the providers which are already started such as HadoopInfrastructureProvider, it will be started again in the process of "Start the rest of the providers." - Dian ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40635/#review110492 ----------------------------------------------------------- On Dec. 14, 2015, 8:03 a.m., Dian Fu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/40635/ > ----------------------------------------------------------- > > (Updated Dec. 14, 2015, 8:03 a.m.) > > > Review request for Sqoop. > > > Bugs: SQOOP-2705 > https://issues.apache.org/jira/browse/SQOOP-2705 > > > Repository: sqoop-sqoop2 > > > Description > ------- > > At the first step of providing kerberos support for integration tests, I'd > like to add kerberos support for SqoopMiniCluster make sure the communication > between sqoop client and sqoop server are kerberos enabled. > > > Diffs > ----- > > pom.xml e66de4d > test/pom.xml 4e1e197 > test/src/main/java/org/apache/sqoop/test/infrastructure/SqoopTestCase.java > c1f355f > > test/src/main/java/org/apache/sqoop/test/infrastructure/providers/DatabaseInfrastructureProvider.java > e4481c4 > > test/src/main/java/org/apache/sqoop/test/infrastructure/providers/HadoopInfrastructureProvider.java > f6ba23c > > test/src/main/java/org/apache/sqoop/test/infrastructure/providers/InfrastructureProvider.java > d904b3e > > test/src/main/java/org/apache/sqoop/test/infrastructure/providers/KdcInfrastructureProvider.java > PRE-CREATION > > test/src/main/java/org/apache/sqoop/test/infrastructure/providers/SqoopInfrastructureProvider.java > 2c8af9c > test/src/main/java/org/apache/sqoop/test/kdc/KdcRunner.java PRE-CREATION > test/src/main/java/org/apache/sqoop/test/kdc/KdcRunnerFactory.java > PRE-CREATION > test/src/main/java/org/apache/sqoop/test/kdc/MiniKdcRunner.java > PRE-CREATION > test/src/main/java/org/apache/sqoop/test/kdc/NoKerberosKdcRunner.java > PRE-CREATION > > test/src/main/java/org/apache/sqoop/test/minicluster/JettySqoopMiniCluster.java > 325a790 > test/src/main/java/org/apache/sqoop/test/minicluster/SqoopMiniCluster.java > 9ae941f > > test/src/main/java/org/apache/sqoop/test/minicluster/SqoopMiniClusterFactory.java > 544d419 > test/src/main/java/org/apache/sqoop/test/testcases/JettyTestCase.java > e3ee300 > test/src/main/java/org/apache/sqoop/test/utils/SqoopUtils.java 5964bcd > > test/src/test/java/org/apache/sqoop/integration/server/InformalObjectNameTest.java > fe04df7 > > test/src/test/java/org/apache/sqoop/integration/server/ShowJobInOrderTest.java > 298ec09 > > test/src/test/java/org/apache/sqoop/integration/server/SubmissionWithDisabledModelObjectsTest.java > b309c86 > test/src/test/java/org/apache/sqoop/integration/server/VersionTest.java > e86a6cc > test/src/test/java/org/apache/sqoop/integration/server/rest/RestTest.java > 20f09e8 > > Diff: https://reviews.apache.org/r/40635/diff/ > > > Testing > ------- > > > Thanks, > > Dian Fu > >
