----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42951/#review117025 -----------------------------------------------------------
connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcExecutor.java (line 317) <https://reviews.apache.org/r/42951/#comment178084> setObject(null) connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsExtractor.java (line 24) <https://reviews.apache.org/r/42951/#comment178086> split out to separate jira connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsExtractor.java <https://reviews.apache.org/r/42951/#comment178087> close recordreader (try with resource) test/src/test/java/org/apache/sqoop/integration/connector/hdfs/NullValueTest.java (line 67) <https://reviews.apache.org/r/42951/#comment178092> use crossProduct test/src/test/java/org/apache/sqoop/integration/connector/hdfs/NullValueTest.java (line 89) <https://reviews.apache.org/r/42951/#comment178093> remove nullcheck test/src/test/java/org/apache/sqoop/integration/connector/hdfs/NullValueTest.java (line 219) <https://reviews.apache.org/r/42951/#comment178097> 3 - Abraham Fine On Jan. 29, 2016, 7:35 p.m., Abraham Fine wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/42951/ > ----------------------------------------------------------- > > (Updated Jan. 29, 2016, 7:35 p.m.) > > > Review request for Sqoop. > > > Bugs: sqoop-2808 > https://issues.apache.org/jira/browse/sqoop-2808 > > > Repository: sqoop-sqoop2 > > > Description > ------- > > Sqoop2: Integration tests should test rows with null values > > > Diffs > ----- > > > common-test/src/main/java/org/apache/sqoop/common/test/asserts/ProviderAsserts.java > 4e1ef6a2586ab7cf0582b42e7fe6a6d6b3fd5d50 > > connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcExecutor.java > 7c943c2b44f444f8b8eab914acd2f312fedeeef8 > > connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsExtractor.java > a813c479a07d68e14ed49936f642e762e5b37437 > > connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsLoader.java > 774221aaf5c8cdb8d26ca108fae239598b42229b > > connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsPartition.java > 644de60581faf90ceb2fcef8d3e0544067791fcc > > connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/SqoopTaskAttemptContext.java > PRE-CREATION > > connector/connector-hdfs/src/test/java/org/apache/sqoop/connector/hdfs/TestExtractor.java > 7d2177fd89735b80e43d26d4ff9d89bf3cab64aa > > connector/connector-hdfs/src/test/java/org/apache/sqoop/connector/hdfs/TestLoader.java > 11fcef2a38209c79928f582cf8aa03e889247f22 > > connector/connector-sdk/src/main/java/org/apache/sqoop/connector/common/SqoopIDFUtils.java > 9b0885ada3a914719aeaa70417bca7f41e71257f > > connector/connector-sdk/src/main/java/org/apache/sqoop/connector/idf/AVROIntermediateDataFormat.java > d78fa8b72ecfe62eeec240e01597e7f2a7e4dd76 > > connector/connector-sdk/src/main/java/org/apache/sqoop/connector/idf/JSONIntermediateDataFormat.java > 8db4d3da2eae33772f6f3c82ce0a1f2f2127ae02 > > connector/connector-sdk/src/test/java/org/apache/sqoop/connector/idf/TestAVROIntermediateDataFormat.java > 703ed0a071afe055ed5ad953ed47987ea96468b7 > > connector/connector-sdk/src/test/java/org/apache/sqoop/connector/idf/TestCSVIntermediateDataFormat.java > 040dbfcc9a8b6fea75e4e5f263cf125b123b00b2 > > connector/connector-sdk/src/test/java/org/apache/sqoop/connector/idf/TestJSONIntermediateDataFormat.java > bcc1f95911aa7c51fad9bb902264ca610e3bd0e3 > > test/src/test/java/org/apache/sqoop/integration/connector/hdfs/NullValueTest.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/42951/diff/ > > > Testing > ------- > > yes > > > Thanks, > > Abraham Fine > >
