> On March 7, 2016, 9:03 p.m., Abraham Fine wrote: > > test/src/test/java/org/apache/sqoop/integration/server/rest/DriverRestTest.java, > > lines 29-33 > > <https://reviews.apache.org/r/44410/diff/1/?file=1281394#file1281394line29> > > > > perhaps there would be value in testing the contents of the response > > somehow? > > > > is there some text that we know would always be in the serialized > > version of the driver?
Yeah good idea. I've added few strings to verify in my next iteration. Let me know if that is sufficient from your perspective. - Jarek ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44410/#review122375 ----------------------------------------------------------- On March 7, 2016, 11:11 p.m., Jarek Cecho wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44410/ > ----------------------------------------------------------- > > (Updated March 7, 2016, 11:11 p.m.) > > > Review request for Sqoop and Jarek Cecho. > > > Bugs: SQOOP-2870 > https://issues.apache.org/jira/browse/SQOOP-2870 > > > Repository: sqoop-sqoop2 > > > Description > ------- > > I would like to addd small test case covering {{DriverHandler}} module > similarly as we're building for other REST endpoints. > > > Diffs > ----- > > server/src/main/java/org/apache/sqoop/handler/DriverRequestHandler.java > 95a3291 > > test/src/test/java/org/apache/sqoop/integration/server/rest/DriverRestTest.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/44410/diff/ > > > Testing > ------- > > > Thanks, > > Jarek Cecho > >
