-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46063/#review129429
-----------------------------------------------------------




repository/repository-common/src/main/java/org/apache/sqoop/repository/common/CommonRepositoryInsertUpdateDeleteSelectQuery.java
 (lines 323 - 330)
<https://reviews.apache.org/r/46063/#comment192852>

    I understand the additional joins here, but is it intentional to get rid of 
the ORDER BY?


Jarcec

- Jarek Cecho


On April 18, 2016, 8:35 p.m., Abraham Fine wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46063/
> -----------------------------------------------------------
> 
> (Updated April 18, 2016, 8:35 p.m.)
> 
> 
> Review request for Sqoop.
> 
> 
> Bugs: SQOOP-2900
>     https://issues.apache.org/jira/browse/SQOOP-2900
> 
> 
> Repository: sqoop-sqoop2
> 
> 
> Description
> -------
> 
> Support encrypting map inputs with sensitive fields
> 
> 
> Diffs
> -----
> 
>   
> common/src/main/java/org/apache/sqoop/json/util/ConfigInputSerialization.java 
> 4ce977cf43822314c4d34b0fb48ceffd80eb9bd8 
>   
> repository/repository-common/src/main/java/org/apache/sqoop/repository/common/CommonRepositoryHandler.java
>  4cae8113b2a935cc294922108f8c573e5f090513 
>   
> repository/repository-common/src/main/java/org/apache/sqoop/repository/common/CommonRepositoryInsertUpdateDeleteSelectQuery.java
>  91187225c3cecf69727e32ab40df41138faa86cd 
>   
> test/src/test/java/org/apache/sqoop/integration/tools/RepositoryEncryptionToolTest.java
>  5f588f5ac167bf0f1f4309deafe655653528b36e 
>   
> tools/src/main/java/org/apache/sqoop/tools/tool/RepositoryEncryptionTool.java 
> d0eab40c4a83c8c536c0af26bd91565d49f2661c 
> 
> Diff: https://reviews.apache.org/r/46063/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Abraham Fine
> 
>

Reply via email to