-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52212/
-----------------------------------------------------------

(Updated Nov. 4, 2016, 9:29 a.m.)


Review request for Sqoop, Boglarka Egyed, Chris Teoh, Attila Szabo, Anna 
Szonyi, and Szabolcs Vasas.


Changes
-------

(renaming methods)


Bugs: SQOOP-3013
    https://issues.apache.org/jira/browse/SQOOP-3013


Repository: sqoop-trunk


Description
-------

When setting job configurations and adding files to "tmpjars", Sqoop does not 
sanitize the list of empty strings.
Sqoop should remove empty strings before starting the MR job and raise a 
warning if an empty string was found.

The proposed changes check for empty strings in "tmpjars" and remove them along 
with raising a warning.


Diffs (updated)
-----

  src/java/org/apache/sqoop/mapreduce/JobBase.java 7ed2684 
  src/test/org/apache/sqoop/mapreduce/TestJobBase.java PRE-CREATION 

Diff: https://reviews.apache.org/r/52212/diff/


Testing
-------

- Live test with command including: "tmpjars=,,valid,,,validother,,,"
- Unit tests


Thanks,

Erzsebet Szilagyi

Reply via email to