----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56914/#review166503 -----------------------------------------------------------
Hi Suraj, Thank you for the patch, it seems good to me, however I would be glad if you could add new test case(s) to prove that your solution works. Thanks, Szabolcs - Szabolcs Vasas On Feb. 22, 2017, 5:12 a.m., Suraj Nayak wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56914/ > ----------------------------------------------------------- > > (Updated Feb. 22, 2017, 5:12 a.m.) > > > Review request for Sqoop. > > > Repository: sqoop-trunk > > > Description > ------- > > Netezza Direct import Mapper is not sensitive to columns option. The > parameters passed to --columns C1,C2,C3,C4 are ignored by > NetezzaExternalTableImportMapper. > NetezzaExternalTableImportMapper on line 83 is based of output field names > instead of input field names. > Even when -D mapreduce.jdbc.output.field.names=C1,C2,C3,C4 is set, another > bug in NetezzaExternalTableImportMapper @ line 128 duplicates the first > column. This is due to the for loop initialization bug where variable i > should be initialized to 1 instead of 0. > > > Diffs > ----- > > > src/java/org/apache/sqoop/mapreduce/db/netezza/NetezzaExternalTableImportMapper.java > 2efea53 > > Diff: https://reviews.apache.org/r/56914/diff/ > > > Testing > ------- > > Manually ran ant test. All test cases passed. Build successful. > > > Thanks, > > Suraj Nayak > >
