----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57736/#review169329 -----------------------------------------------------------
Fix it, then Ship it! src/test/com/cloudera/sqoop/manager/PostgresqlExportTest.java Lines 76-79 (patched) <https://reviews.apache.org/r/57736/#comment241693> Hey Bogi, Why is this method protected? Do we need it in any descendant of this class? src/test/com/cloudera/sqoop/manager/PostgresqlImportTest.java Lines 124-127 (patched) <https://reviews.apache.org/r/57736/#comment241692> Hey Bogi, Why is this method protected? Do we need it in any descendant of this class? - Attila Szabo On March 17, 2017, 9:21 p.m., Boglarka Egyed wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57736/ > ----------------------------------------------------------- > > (Updated March 17, 2017, 9:21 p.m.) > > > Review request for Sqoop and Anna Szonyi. > > > Bugs: SQOOP-3105 > https://issues.apache.org/jira/browse/SQOOP-3105 > > > Repository: sqoop-trunk > > > Description > ------- > > Added database clean-up logic in Postgres Tests at tearDown part > > > Diffs > ----- > > src/test/com/cloudera/sqoop/manager/PostgresqlExportTest.java > ed5917f7134efd738b4ac78083481aa84be44c9a > src/test/com/cloudera/sqoop/manager/PostgresqlImportTest.java > 70ee6403aa53f463102d762d5243e752ff73ef24 > > > Diff: https://reviews.apache.org/r/57736/diff/1/ > > > Testing > ------- > > ant clean test > ant clean test -Dthirdparty=true -Dsqoop.thirdparty.lib.dir=$3rdpartylib > -Dsqoop.test.postgresql.connectstring.host_url=$connstr > -Dtestcase=*ostgresql*Test > > > Thanks, > > Boglarka Egyed > >
