-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57551/
-----------------------------------------------------------

(Updated March 20, 2017, 8:13 a.m.)


Review request for Sqoop, Attila Szabo and Szabolcs Vasas.


Changes
-------

missed file testdata/hive/scripts/decimalImport.q, and added one more test case.


Repository: sqoop-trunk


Description
-------

Currently Sqoop converts DECIMAL from RDMS into DOUBLE in Hive, which is not 
correct as user will lose precisions. Since Hive supports DECIMAL long ago, we 
should support DECIMAL to DECIMAL conversion from Sqoop to Hive.


Diffs (updated)
-----

  src/java/org/apache/sqoop/hive/HiveTypes.java ad00535 
  src/java/org/apache/sqoop/hive/TableDefWriter.java 32fcca3 
  src/test/com/cloudera/sqoop/hive/TestHiveImport.java 1d67a2d 
  src/test/com/cloudera/sqoop/hive/TestTableDefWriter.java 4db629f 
  testdata/hive/scripts/decimalImport.q PRE-CREATION 


Diff: https://reviews.apache.org/r/57551/diff/3/

Changes: https://reviews.apache.org/r/57551/diff/2-3/


Testing
-------

Test case + maunaul test


Thanks,

Eric Lin

Reply via email to