----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59831/#review177041 -----------------------------------------------------------
Ship it! Hi Szabi, I ran the unit and the third party tests with your patch successfully. Thanks for the fix, nice catch! Thanks, Bogi - Boglarka Egyed On June 6, 2017, 10:04 a.m., Szabolcs Vasas wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/59831/ > ----------------------------------------------------------- > > (Updated June 6, 2017, 10:04 a.m.) > > > Review request for Sqoop. > > > Bugs: SQOOP-3194 > https://issues.apache.org/jira/browse/SQOOP-3194 > > > Repository: sqoop-trunk > > > Description > ------- > > org.apache.sqoop.hcat.HCatalogTestUtils#assertSqlColValForRowId: the colname > should be always escaped, since this is the approach taken in the creation > SQL command as well in > org.apache.sqoop.hcat.HCatalogTestUtils#getSqlCreateTableStatement. > > > Diffs > ----- > > src/test/org/apache/sqoop/hcat/HCatalogExportTest.java 32add56 > src/test/org/apache/sqoop/hcat/HCatalogTestUtils.java 4301a33 > > > Diff: https://reviews.apache.org/r/59831/diff/1/ > > > Testing > ------- > > I ran all the Sqoop tests (unit tests and third party tests) with the patch. > > > Thanks, > > Szabolcs Vasas > >
