----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59346/#review180934 -----------------------------------------------------------
src/java/org/apache/sqoop/mapreduce/MergeGenericRecordExportMapper.java Lines 37 (patched) <https://reviews.apache.org/r/59346/#comment256287> Can you remove these comments src/java/org/apache/sqoop/mapreduce/MergeGenericRecordExportMapper.java Lines 38 (patched) <https://reviews.apache.org/r/59346/#comment256288> Var name can be isNewDatasetSplit src/java/org/apache/sqoop/mapreduce/MergeJob.java Lines 230 (patched) <https://reviews.apache.org/r/59346/#comment256290> Can this be a final string value - Akshay Shet On July 19, 2017, 4:08 p.m., Sandish Kumar HN wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/59346/ > ----------------------------------------------------------- > > (Updated July 19, 2017, 4:08 p.m.) > > > Review request for Sqoop, Boglarka Egyed, Attila Szabo, and Szabolcs Vasas. > > > Bugs: PARQUET-1010 and SQOOP-3178 > https://issues.apache.org/jira/browse/PARQUET-1010 > https://issues.apache.org/jira/browse/SQOOP-3178 > > > Repository: sqoop-trunk > > > Description > ------- > > New feature for sqoop-1: Sqoop Merge and Incremental Merge for Parquet File > Format > > > Diffs > ----- > > src/java/org/apache/sqoop/mapreduce/MergeGenericRecordExportMapper.java > PRE-CREATION > src/java/org/apache/sqoop/mapreduce/MergeJob.java 8b1cba33 > src/java/org/apache/sqoop/mapreduce/MergeParquetMapper.java PRE-CREATION > src/java/org/apache/sqoop/mapreduce/MergeParquetReducer.java PRE-CREATION > src/java/org/apache/sqoop/tool/ImportTool.java 78c7758e > src/test/com/cloudera/sqoop/TestMerge.java 114e934a > > > Diff: https://reviews.apache.org/r/59346/diff/10/ > > > Testing > ------- > > Hi, > > I have written a Sqoop Merge and Incremental Merge MR for Parquet File > Format and I have tested with million records of data with N number of > iterations. Please review My patch. > > THIS ISSUE HAS DEPENDANCY ON PARQUET BUG. SO I HAVE RESOLVED THE PARQUET > ISSUE AND CREATED A PATCH FOR IT HERE > https://issues.apache.org/jira/browse/PARQUET-1010 > > Please let me know if there are any mistakes in My patch > > > Thanks, > > Sandish Kumar HN > >
