----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61777/#review183317 -----------------------------------------------------------
src/test/org/apache/sqoop/mapreduce/db/TestSQLServerDBRecordReader.java Lines 33 (patched) <https://reviews.apache.org/r/61777/#comment259355> We try to avoid star imports, can you please organize this import accordingly? src/test/org/apache/sqoop/mapreduce/db/TestSQLServerDBRecordReader.java Lines 39 (patched) <https://reviews.apache.org/r/61777/#comment259356> Nit: can we use SPLIT_BY_COLUMN.toUpperCase() here? - Szabolcs Vasas On Aug. 21, 2017, 9:16 a.m., Zoltán Tóth wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/61777/ > ----------------------------------------------------------- > > (Updated Aug. 21, 2017, 9:16 a.m.) > > > Review request for Sqoop. > > > Bugs: SQOOP-3139 > https://issues.apache.org/jira/browse/SQOOP-3139 > > > Repository: sqoop-trunk > > > Description > ------- > > In the case if the database table name and split-by parameter was different > (eg.: Mycol vs. mycol) Sqoop couldn't continue the query from the last value > if the connection was broken. > > > Diffs > ----- > > src/java/org/apache/sqoop/mapreduce/db/DBRecordReader.java a78eb061 > src/java/org/apache/sqoop/mapreduce/db/SQLServerDBRecordReader.java > 9a3621b0 > src/test/org/apache/sqoop/mapreduce/db/TestSQLServerDBRecordReader.java > PRE-CREATION > > > Diff: https://reviews.apache.org/r/61777/diff/1/ > > > Testing > ------- > > > Thanks, > > Zoltán Tóth > >
