> On Aug. 22, 2017, 2:49 p.m., Sandish Kumar HN wrote: > > Is it possible to add few more test cases??
Hi Sandish, Do you have any specific aspects you'd like to see tested more? - Zach ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61372/#review183475 ----------------------------------------------------------- On Aug. 17, 2017, 12:45 p.m., Zach Berkowitz wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/61372/ > ----------------------------------------------------------- > > (Updated Aug. 17, 2017, 12:45 p.m.) > > > Review request for Sqoop, Boglarka Egyed, Jarek Cecho, and Anna Szonyi. > > > Bugs: SQOOP-3216 > https://issues.apache.org/jira/browse/SQOOP-3216 > > > Repository: sqoop-trunk > > > Description > ------- > > Expanded Metastore support for MySql, Oracle, Postgresql, MSSql, and DB2 > > > Diffs > ----- > > src/docs/user/metastore-purpose.txt e7eb23d3 > src/docs/user/saved-jobs.txt e8757801 > src/java/com/cloudera/sqoop/metastore/hsqldb/AutoHsqldbStorage.java > 259d9f63 > src/java/com/cloudera/sqoop/metastore/hsqldb/HsqldbJobStorage.java 083e2a37 > src/java/org/apache/sqoop/SqoopOptions.java 2eb3d8a4 > src/java/org/apache/sqoop/manager/CubridManager.java 5a1a0e83 > src/java/org/apache/sqoop/manager/Db2Manager.java 61b6868d > src/java/org/apache/sqoop/manager/HsqldbManager.java 9b9c5822 > src/java/org/apache/sqoop/manager/JdbcDrivers.java PRE-CREATION > src/java/org/apache/sqoop/manager/MySQLManager.java 3c2276fe > src/java/org/apache/sqoop/manager/NetezzaManager.java 0ac77175 > src/java/org/apache/sqoop/manager/OracleManager.java 2f4585cc > src/java/org/apache/sqoop/manager/PostgresqlManager.java 44e041ad > src/java/org/apache/sqoop/manager/SQLServerManager.java 9a3d9183 > src/java/org/apache/sqoop/manager/SupportedManagers.java 8a6037af > src/java/org/apache/sqoop/metastore/JobStorageFactory.java 2edc33b8 > src/java/org/apache/sqoop/metastore/hsqldb/AutoHsqldbStorage.java 49e30319 > src/java/org/apache/sqoop/metastore/hsqldb/HsqldbJobStorage.java a0f29fd0 > src/java/org/apache/sqoop/tool/BaseSqoopTool.java 1564bdcb > src/java/org/apache/sqoop/tool/JobTool.java 054e274f > src/test/com/cloudera/sqoop/TestIncrementalImport.java 52a55b78 > src/test/com/cloudera/sqoop/metastore/JobToolTest.java PRE-CREATION > src/test/com/cloudera/sqoop/metastore/MetaConnectIncrementalImportTest.java > PRE-CREATION > src/test/com/cloudera/sqoop/metastore/TestSavedJobs.java 61d8c97d > src/test/com/cloudera/sqoop/metastore/db2/DB2JobToolTest.java PRE-CREATION > > src/test/com/cloudera/sqoop/metastore/db2/DB2MetaConnectIncrementalImportTest.java > PRE-CREATION > src/test/com/cloudera/sqoop/metastore/db2/DB2SavedJobsTest.java > PRE-CREATION > src/test/com/cloudera/sqoop/metastore/hsqldb/HsqldbJobToolTest.java > PRE-CREATION > > src/test/com/cloudera/sqoop/metastore/hsqldb/HsqldbMetaConnectIncrementalImportTest.java > PRE-CREATION > src/test/com/cloudera/sqoop/metastore/hsqldb/HsqldbSavedJobsTest.java > PRE-CREATION > src/test/com/cloudera/sqoop/metastore/mysql/MySqlJobToolTest.java > PRE-CREATION > > src/test/com/cloudera/sqoop/metastore/mysql/MySqlMetaConnectIncrementalImportTest.java > PRE-CREATION > src/test/com/cloudera/sqoop/metastore/mysql/MySqlSavedJobsTest.java > PRE-CREATION > src/test/com/cloudera/sqoop/metastore/oracle/OracleJobToolTest.java > PRE-CREATION > > src/test/com/cloudera/sqoop/metastore/oracle/OracleMetaConnectIncrementalImportTest.java > PRE-CREATION > src/test/com/cloudera/sqoop/metastore/oracle/OracleSavedJobsTest.java > PRE-CREATION > src/test/com/cloudera/sqoop/metastore/postgres/PostgresJobToolTest.java > PRE-CREATION > > src/test/com/cloudera/sqoop/metastore/postgres/PostgresMetaConnectIncrementalImportTest.java > PRE-CREATION > src/test/com/cloudera/sqoop/metastore/postgres/PostgresSavedJobsTest.java > PRE-CREATION > src/test/com/cloudera/sqoop/metastore/sqlserver/SqlServerJobToolTest.java > PRE-CREATION > > src/test/com/cloudera/sqoop/metastore/sqlserver/SqlServerMetaConnectIncrementalImportTest.java > PRE-CREATION > src/test/com/cloudera/sqoop/metastore/sqlserver/SqlServerSavedJobsTest.java > PRE-CREATION > src/test/findbugsExcludeFile.xml a27ec378 > > > Diff: https://reviews.apache.org/r/61372/diff/2/ > > > Testing > ------- > > Three test classes SavedJobsTest, MetaConnectIncrementalImportTest, and > JobToolTest all pass for all supported databases. > > > Thanks, > > Zach Berkowitz > >
