----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61669/#review184135 -----------------------------------------------------------
Fix it, then Ship it! Hi Szabi, I have a very minor finding regarding your change otherwise it looks good and well organized. Thanks for filling this test gap and especially for cleaning up the setUp in HBaseTestCase. Regards, Bogi src/test/com/cloudera/sqoop/hbase/HBaseKerberizedConnectivityTest.java Lines 26 (patched) <https://reviews.apache.org/r/61669/#comment260196> Could you please remove the space from here between String and []? - Boglarka Egyed On Aug. 25, 2017, 10:06 p.m., Szabolcs Vasas wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/61669/ > ----------------------------------------------------------- > > (Updated Aug. 25, 2017, 10:06 p.m.) > > > Review request for Sqoop, Boglarka Egyed, Ferenc Szabo, and Zoltán Tóth. > > > Bugs: SQOOP-3222 > https://issues.apache.org/jira/browse/SQOOP-3222 > > > Repository: sqoop-trunk > > > Description > ------- > > In this patch I have changed the following: > - Added test dependency on hadoop-minikdc. > - Added a JUnit rule which starts/stops kerberos MiniKdc before/after a test > case/class. > - Added kerberos handling logic to HBaseTestCase and refactored it a bit. > - Removed the kerberos-related properties from the build.xml as they caused > HBaseKerberizedConnectivityTest to fail. > > The changes are inspired by the following HBase test classes: > https://github.com/apache/hbase/blob/master/hbase-server/src/test/java/org/apache/hadoop/hbase/security/token/SecureTestCluster.java > https://github.com/apache/hbase/blob/master/hbase-server/src/test/java/org/apache/hadoop/hbase/security/token/TestGenerateDelegationToken.java > > > HBase security documentation: > http://hbase.apache.org/1.2/book.html#security > > > Diffs > ----- > > build.xml 5f02dcf7759887d84d8cf0505cc1873c53f70a67 > ivy.xml e4b45bfd9ff6d984a1d1d1808855a07d8b090921 > src/test/com/cloudera/sqoop/hbase/HBaseKerberizedConnectivityTest.java > PRE-CREATION > src/test/com/cloudera/sqoop/hbase/HBaseTestCase.java > d9f74952e5f9dd9497e6e9e99789471bcd8f8930 > > src/test/org/apache/sqoop/infrastructure/kerberos/KerberosConfigurationProvider.java > PRE-CREATION > > src/test/org/apache/sqoop/infrastructure/kerberos/MiniKdcInfrastructure.java > PRE-CREATION > > src/test/org/apache/sqoop/infrastructure/kerberos/MiniKdcInfrastructureRule.java > PRE-CREATION > > > Diff: https://reviews.apache.org/r/61669/diff/4/ > > > Testing > ------- > > Ran unit tests and third party tests. > > > Thanks, > > Szabolcs Vasas > >
