> On Sept. 8, 2017, 2:14 p.m., Zoltán Tóth wrote: > > src/java/org/apache/sqoop/mapreduce/HBaseBulkImportJob.java > > Lines 98 (patched) > > <https://reviews.apache.org/r/62028/diff/1/?file=1810654#file1810654line98> > > > > Don't you want to log if it cannot get HBaseTable? Maybe it will be > > logged on higher level
The exception is rethrown after the connection is closed we do not need to log it. > On Sept. 8, 2017, 2:14 p.m., Zoltán Tóth wrote: > > src/java/org/apache/sqoop/mapreduce/HBaseBulkImportJob.java > > Lines 130 (patched) > > <https://reviews.apache.org/r/62028/diff/1/?file=1810654#file1810654line130> > > > > Can you change general exception into specified ones? Unfortunately the constructor of LoadIncrementalHFiles throws an Exception so we cannot be more specific here... > On Sept. 8, 2017, 2:14 p.m., Zoltán Tóth wrote: > > src/java/org/apache/sqoop/mapreduce/HBaseBulkImportJob.java > > Lines 149 (patched) > > <https://reviews.apache.org/r/62028/diff/1/?file=1810654#file1810654line149> > > > > If the error message is not neccessary then you can leave the exception > > to be thrown to to the caller method. This is just a finally block which closes the HBase connection the original exception will be thrown to the caller. - Szabolcs ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62028/#review184973 ----------------------------------------------------------- On Sept. 11, 2017, 9:58 a.m., Szabolcs Vasas wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/62028/ > ----------------------------------------------------------- > > (Updated Sept. 11, 2017, 9:58 a.m.) > > > Review request for Sqoop. > > > Bugs: SQOOP-3232 > https://issues.apache.org/jira/browse/SQOOP-3232 > > > Repository: sqoop-trunk > > > Description > ------- > > Sqoop currently depends on pre HBase 1.0 APIs that have been deprecated and > will be removed in the HBase 2.0 release. > The task is to remove the dependency on these old APIs to make sure that the > upgrade to a newer HBase version will be easier in the future. > > > Diffs > ----- > > src/java/org/apache/sqoop/hbase/HBasePutProcessor.java > 032fd38ad0ff13372ae70be47e38db8c4ba8ef8f > src/java/org/apache/sqoop/mapreduce/HBaseBulkImportJob.java > 2bbfffe03844517da9d0d7c94380a8fb57c5eb29 > src/java/org/apache/sqoop/mapreduce/HBaseImportJob.java > 523d0a7ede70e16b4e80f8349f08c67eba2e4d01 > src/test/com/cloudera/sqoop/hbase/HBaseTestCase.java > 8b29b5fdb00e223a4f2af14b8a9cbfd9ba9d7d83 > src/test/org/apache/sqoop/hbase/TestHBasePutProcessor.java PRE-CREATION > > > Diff: https://reviews.apache.org/r/62028/diff/2/ > > > Testing > ------- > > Added a new test case for the small refactoring I did. > Ran all unit and third party tests successfully. > > > Thanks, > > Szabolcs Vasas > >
