----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62057/#review185076 -----------------------------------------------------------
src/java/org/apache/sqoop/mapreduce/hcat/SqoopHCatImportHelper.java Lines 449 (patched) <https://reviews.apache.org/r/62057/#comment261296> I think this method could be non-static. src/test/org/apache/sqoop/hcat/HCatalogImportTest.java Lines 404 (patched) <https://reviews.apache.org/r/62057/#comment261292> Can you please extract the magic constants to make this test more readable? src/test/org/apache/sqoop/mapreduce/hcat/TestSqoopHCatImportHelper.java Lines 28 (patched) <https://reviews.apache.org/r/62057/#comment261297> Nit: please remove this extra new line here. src/test/org/apache/sqoop/mapreduce/hcat/TestSqoopHCatImportHelper.java Lines 31 (patched) <https://reviews.apache.org/r/62057/#comment261298> Nit: please remove these extra 2 lines here. - Szabolcs Vasas On Sept. 5, 2017, 3:32 p.m., Zoltán Tóth wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/62057/ > ----------------------------------------------------------- > > (Updated Sept. 5, 2017, 3:32 p.m.) > > > Review request for Sqoop, Boglarka Egyed and Anna Szonyi. > > > Bugs: SQOOP-3014 > https://issues.apache.org/jira/browse/SQOOP-3014 > > > Repository: sqoop-trunk > > > Description > ------- > > HCatalog rounded BigDecimals but that should not happen. Now Sqoop HCatalog > doesn't change BigDecimals > > > Diffs > ----- > > src/java/org/apache/sqoop/mapreduce/hcat/SqoopHCatImportHelper.java > aba2458e > src/test/org/apache/sqoop/hcat/HCatalogImportTest.java d784a205 > src/test/org/apache/sqoop/mapreduce/hcat/TestSqoopHCatImportHelper.java > PRE-CREATION > > > Diff: https://reviews.apache.org/r/62057/diff/2/ > > > Testing > ------- > > I ran unit tests and integration tests as well. New test cases were added to > test the change > > > Thanks, > > Zoltán Tóth > >
