> On Nov. 16, 2017, 1:43 p.m., Szabolcs Vasas wrote: > > Hi Sandish, > > > > I have took another look at your patch and I think there is some confusion > > here. > > > > * The JIRA description says that create-hive-table tool needs to be > > improved to be able to create Parquet and Avro tables too (schema only). > > The problem is that there is a --create-hive-table option as well which is > > a totally different thing. The --create-hive-table option gets mapped to > > org.apache.sqoop.SqoopOptions#failIfHiveTableExists boolean value (which is > > a much better description) and it means that Sqoop job gets aborted if the > > Hive table already exist. I think your patch tries to address the > > --create-hive-table option so it should be done under a different JIRA. > > * Based on the code you try to include 2 changes in this patch and I think > > they should be separated. > > * The first thing was the Parquet Hive table creation changes in > > TableDefWriter. The problem is that I think this code never gets executed > > since org.apache.sqoop.hive.HiveImport#importTable never gets invoked if we > > import into Parquet files. See: org/apache/sqoop/tool/ImportTool.java:539 > > * The other thing is the Avro support for Hive tables. I think this part > > still needs more testing with possibly all the supported data types and > > codecs. > > > > Regards, > > Szabolcs
Hi @vasas, Thanks for review, I will create two seperate JIRA issues for this patch. One for "Sqoop import parquet support" and "Sqoop import Avro support" - Sandish Kumar ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61882/#review191177 ----------------------------------------------------------- On Oct. 23, 2017, 12:30 p.m., Sandish Kumar HN wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/61882/ > ----------------------------------------------------------- > > (Updated Oct. 23, 2017, 12:30 p.m.) > > > Review request for Sqoop and Anna Szonyi. > > > Bugs: SQOOP-3215 > https://issues.apache.org/jira/browse/SQOOP-3215 > > > Repository: sqoop-trunk > > > Description > ------- > > sqoop import and create hive table as formats(avro,parquet) > > > Diffs > ----- > > src/java/org/apache/sqoop/hive/TableDefWriter.java deec32d6 > src/java/org/apache/sqoop/tool/BaseSqoopTool.java 6a4dcb09 > src/test/com/cloudera/sqoop/hive/TestHiveImport.java a624f52b > testdata/hive/scripts/normalHiveImportAvro.q PRE-CREATION > > > Diff: https://reviews.apache.org/r/61882/diff/2/ > > > Testing > ------- > > testNormalHiveImportAsAvro, testNormalHiveImportAsParquet with table creation > checks. > > > Thanks, > > Sandish Kumar HN > >
