-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64333/
-----------------------------------------------------------

Review request for Sqoop.


Bugs: SQOOP-3267
    https://issues.apache.org/jira/browse/SQOOP-3267


Repository: sqoop-trunk


Description
-------

Deletes are supported since SQOOP-3149, but we're only deleting the last 
version of a column when the corresponding cell was set to NULL in the source 
table.

This can lead to unexpected and misleading results if the row has been 
transferred multiple times, which can easily happen if it's being modified on 
the source side.

Also SQOOP-3149 is using a new Put command for every column instead of a single 
Put per row as before. This could probably lead to a performance drop for wide 
tables (for which HBase is otherwise usually recommended).


Diffs
-----

  src/java/org/apache/sqoop/hbase/ToStringPutTransformer.java 
20bf1b96c369613672725e171fe9dc0469feb294 


Diff: https://reviews.apache.org/r/64333/diff/1/


Testing
-------


Thanks,

daniel voros

Reply via email to