[ 
https://issues.apache.org/jira/browse/SQOOP-3289?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16377022#comment-16377022
 ] 

Daniel Voros commented on SQOOP-3289:
-------------------------------------

Thanks for your response [~maugli]. I definitely agree with you, we should 
automate all tests (including thirdparty+manual integration tests) and static 
analysis checks as part of a CI gate.

AFAIK ASF is pretty flexible in this matter. For example, Spark's running 
checks on a 3rd party Jenkins on PR hooks, while Hive and Hadoop trigger jobs 
in builds.apache.org Jenkins via Jira attached patches.

None of them do the CI via Travis tho. 
[Hive|https://github.com/apache/hive/blob/master/.travis.yml#L45] and 
[Spark|https://github.com/apache/spark/blob/master/.travis.yml#L46] have 
.travis.ymls but they're not even running tests. I guess that's because of the 
50 min limitation on travis-ci.org runs.

I think we should deal with Travis and CI gatekeeping as separate tasks, and 
open a new Jira for the CI part. What do you think?

BTW, I've just found out that we're already running this job on Jira 
attachments, but it seems to fail recently. (: 
https://builds.apache.org/job/PreCommit-SQOOP-Build/

> Add .travis.yml
> ---------------
>
>                 Key: SQOOP-3289
>                 URL: https://issues.apache.org/jira/browse/SQOOP-3289
>             Project: Sqoop
>          Issue Type: Task
>          Components: build
>    Affects Versions: 1.4.7
>            Reporter: Daniel Voros
>            Assignee: Daniel Voros
>            Priority: Minor
>             Fix For: 1.5.0
>
>
> Adding a .travis.yml would enable running builds/tests on travis-ci.org. 
> Currently if you wish to use Travis for testing your changes, you have to 
> manually add a .travis.yml to your branch. Having it committed to trunk would 
> save us this extra step.
> I currently have an example 
> [{{.travis.yml}}|https://github.com/dvoros/sqoop/blob/93a4c06c1a3da1fd5305c99e379484507797b3eb/.travis.yml]
>  on my travis branch running unit tests for every commit and every pull 
> request: https://travis-ci.org/dvoros/sqoop/builds
> Later we could add the build status to the project readme as well, see: 
> https://github.com/dvoros/sqoop/tree/travis
> Also, an example of a pull request: https://github.com/dvoros/sqoop/pull/1



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to