----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65884/#review198933 -----------------------------------------------------------
src/java/org/apache/sqoop/hive/HiveImport.java Lines 312-316 (patched) <https://reviews.apache.org/r/65884/#comment279212> Hi Dani, I believe the original design that includes the testMode boolean flag, that determines whether we are in a test or not, is quite flawed. One thing you could consider is removing it and use some kind of mocking instead. But, as it's used in 5 tests, this might be an issue with a bigger scope and best captured and solved in a different Jira? (Though that might just get forgotten and lost...) - Fero Szabo On March 2, 2018, 3:39 p.m., daniel voros wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/65884/ > ----------------------------------------------------------- > > (Updated March 2, 2018, 3:39 p.m.) > > > Review request for Sqoop. > > > Bugs: SQOOP-3291 > https://issues.apache.org/jira/browse/SQOOP-3291 > > > Repository: sqoop-trunk > > > Description > ------- > > Job data is published to listeners (defined via sqoop.job.data.publish.class) > in case of Hive and HCat imports. Currently this happens before the Hive > import completes, so it gets reported even if Hive import fails. > > > Diffs > ----- > > src/java/org/apache/sqoop/hive/HiveImport.java c272911 > src/java/org/apache/sqoop/mapreduce/ExportJobBase.java 6529bd2 > src/java/org/apache/sqoop/mapreduce/ImportJobBase.java fb5d054 > src/java/org/apache/sqoop/mapreduce/PublishJobData.java fc18188 > src/java/org/apache/sqoop/tool/ImportTool.java e992005 > src/test/org/apache/sqoop/TestSqoopJobDataPublisher.java b3579ac > src/test/org/apache/sqoop/testutil/BaseSqoopTestCase.java a5f85a0 > > > Diff: https://reviews.apache.org/r/65884/diff/1/ > > > Testing > ------- > > - created unit test > - tested on a cluster with Atlas SqoopHook in place > > > Thanks, > > daniel voros > >
