[ https://issues.apache.org/jira/browse/SQOOP-3224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16405020#comment-16405020 ]
ASF GitHub Bot commented on SQOOP-3224: --------------------------------------- Github user fszabo2 commented on a diff in the pull request: https://github.com/apache/sqoop/pull/44#discussion_r175483531 --- Diff: src/java/org/apache/sqoop/util/MainframeFTPClientUtils.java --- @@ -207,8 +208,18 @@ public static FTPClient getFTPConnection(Configuration conf) throw new IOException("Could not login to server " + server + ":" + ftp.getReplyString()); } - // set ASCII transfer mode - ftp.setFileType(FTP.ASCII_FILE_TYPE); + // set transfer mode + String transferMode = conf.get(MainframeConfiguration.MAINFRAME_FTP_TRANSFER_MODE); --- End diff -- The whole getFTPConnection method is already very long and does a bunch of steps. You could consider refactoring it into smaller methods for readability. > Mainframe FTP transfer should have an option to use binary mode for transfer > ---------------------------------------------------------------------------- > > Key: SQOOP-3224 > URL: https://issues.apache.org/jira/browse/SQOOP-3224 > Project: Sqoop > Issue Type: Improvement > Reporter: Chris Teoh > Assignee: Chris Teoh > Priority: Minor > > Currently the mainframe FTP module is hard coded to use ascii transfer mode. > Propose a mainframe module flag to be able to change modes. -- This message was sent by Atlassian JIRA (v7.6.3#76005)