[
https://issues.apache.org/jira/browse/SQOOP-3308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16419095#comment-16419095
]
Boglarka Egyed edited comment on SQOOP-3308 at 3/29/18 2:34 PM:
----------------------------------------------------------------
Thank you very much for this clean up [~vasas]! Please close the related Review
Request too.
was (Author: boglarkaegyed):
Thank you very much for this clean up [~vasas]! Please cole the related Review
Request too.
> Mock ConnManager field in TestTableDefWriter
> --------------------------------------------
>
> Key: SQOOP-3308
> URL: https://issues.apache.org/jira/browse/SQOOP-3308
> Project: Sqoop
> Issue Type: Sub-task
> Affects Versions: 1.5.0
> Reporter: Szabolcs Vasas
> Assignee: Szabolcs Vasas
> Priority: Major
> Fix For: 1.5.0
>
> Attachments: SQOOP-3308.patch, SQOOP-3308.patch, SQOOP-3308.patch,
> SQOOP-3308.patch
>
>
> TableDefWriter has a dependency on ConnManager to retrieve the names and the
> types of the table. It also introduces a field called _externalColTypes_ for
> testing purposes and TestTableDefWriter uses this field to inject the test
> table column names and types instead of mocking the ConnManager field.
> This setup makes it harder to add test cases to TestTableDefWriter and not a
> good practice so it should be fixed.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
