----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66353/ -----------------------------------------------------------
(Updated April 6, 2018, 1:26 p.m.) Review request for Sqoop. Changes ------- test case for oracle manager formatting Bugs: SQOOP-3306 https://issues.apache.org/jira/browse/SQOOP-3306 Repository: sqoop-trunk Description ------- A fortify scan showed 2 possible resource leaks. 1: The function getRecordWriter() in DBOutputFormat.java sometimes fails to release a database resource allocated by getConnection() on line 117. In the file DBOutputFormat.java similar issues were on line numbers 117 2: The function makeConnection() in OracleManager.java sometimes fails to release a database resource allocated by getConnection() on line 321. In the file OracleManager.java similar issues were on line numbers 321 Diffs (updated) ----- src/java/org/apache/sqoop/manager/OracleManager.java 929b5061 src/java/org/apache/sqoop/mapreduce/db/DBOutputFormat.java 730ff286 src/test/org/apache/sqoop/manager/TestOracleManager.java PRE-CREATION Diff: https://reviews.apache.org/r/66353/diff/2/ Changes: https://reviews.apache.org/r/66353/diff/1-2/ Testing ------- ant test Thanks, Laszlo Bodor