> On April 23, 2018, 2:54 p.m., daniel voros wrote: > > Great stuff! Do you think we'll need ParquetReader in production code when > > removing Kite from the rest of the codebase? If we will, than it probably > > makes sense to move it under src/java now.
Yes, I was thinking about it but at this point I am not sure we will need it since we might be able to use parquet.hadoop.ParquetInputFormat which creates a proper Parquet reader out of the box so at this point I would keep it under test folder. - Szabolcs ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66761/#review201737 ----------------------------------------------------------- On April 23, 2018, 12:21 p.m., Szabolcs Vasas wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66761/ > ----------------------------------------------------------- > > (Updated April 23, 2018, 12:21 p.m.) > > > Review request for Sqoop. > > > Bugs: SQOOP-3318 > https://issues.apache.org/jira/browse/SQOOP-3318 > > > Repository: sqoop-trunk > > > Description > ------- > > Some Sqoop tests use Kite to create test data and verify test results. > > Since we want to remove the Kite dependency from Sqoop we should rewrite > these test cases not to use Kite anymore. > > > Diffs > ----- > > src/java/org/apache/sqoop/util/FileSystemUtil.java 1493e0954 > src/test/org/apache/sqoop/TestAllTables.java 56d1f5772 > src/test/org/apache/sqoop/TestMerge.java 8eef8d4ac > src/test/org/apache/sqoop/TestParquetExport.java c8bb663e0 > src/test/org/apache/sqoop/TestParquetImport.java 379529a8d > src/test/org/apache/sqoop/hive/TestHiveImport.java 4e1f249a8 > src/test/org/apache/sqoop/util/ParquetReader.java PRE-CREATION > > > Diff: https://reviews.apache.org/r/66761/diff/1/ > > > Testing > ------- > > Executed unit and third party tests. > > > Thanks, > > Szabolcs Vasas > >
