----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67005/#review202841 -----------------------------------------------------------
Ship it! Seems ok to me. I've ran unit and 3rd party tests as well. ivy.xml Line 90 (original), 90 (patched) <https://reviews.apache.org/r/67005/#comment284859> I'm not an expert on ant, so just asking for an educational purpose: what does this exactly mean? - Fero Szabo On May 8, 2018, 1:43 p.m., daniel voros wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/67005/ > ----------------------------------------------------------- > > (Updated May 8, 2018, 1:43 p.m.) > > > Review request for Sqoop. > > > Bugs: SQOOP-3322 > https://issues.apache.org/jira/browse/SQOOP-3322 > > > Repository: sqoop-trunk > > > Description > ------- > > We have multiple ivy configurations defined in ivy.xml. > > - The `redist` configuration is used to select the artifacts that need to be > distributed with Sqoop in its tar.gz. > - The `common` configuration is used to set the classpath during compilation > (also refered to as 'hadoop classpath') > - The `test` configuration is used to set the classpath during junit > execution. It extends the `common` config. > > Some artifacts end up having different versions between these three > configurations, which means we're using different versions during > compilation/testing/runtime. > > > Diffs > ----- > > ivy.xml 6af94d9d > ivy/libraries.properties c44b50bc > > > Diff: https://reviews.apache.org/r/67005/diff/1/ > > > Testing > ------- > > - compared the results of ivy-resolve-hadoop, ivy-resolve-test, > ivy-resolve-redist tasks to make sure versions are the same > - checked unit tests just to be on the safe side, test versions weren't > changed though (all passed apart from known issues in SQOOP-3321) > > > Thanks, > > daniel voros > >
