-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67057/#review202845
-----------------------------------------------------------


Ship it!




Tested on Ubuntu and Mac OS too, both passed. Thanks for the fix Daniel!

- Boglarka Egyed


On May 10, 2018, 12:53 p.m., daniel voros wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67057/
> -----------------------------------------------------------
> 
> (Updated May 10, 2018, 12:53 p.m.)
> 
> 
> Review request for Sqoop.
> 
> 
> Bugs: SQOOP-3321
>     https://issues.apache.org/jira/browse/SQOOP-3321
> 
> 
> Repository: sqoop-trunk
> 
> 
> Description
> -------
> 
> I believe this is due to case sensitivity of file names in Linux (as opposed 
> to MacOS). The table name gets converted to lowercase when importing but 
> we're referring to it with it's original casing when trying to verify its 
> contents in ParquetReader.
> 
> Tests are passing after converting these three table names to all lowercase 
> in TestHiveImport:
> 
> - APPEND_HIVE_IMPORT_AS_PARQUET
> - NORMAL_HIVE_IMPORT_AS_PARQUET
> - CREATE_OVERWRITE_HIVE_IMPORT_AS_PARQUET
> 
> 
> Diffs
> -----
> 
>   src/test/org/apache/sqoop/hive/TestHiveImport.java bc19b697 
> 
> 
> Diff: https://reviews.apache.org/r/67057/diff/1/
> 
> 
> Testing
> -------
> 
> Run TestHiveImport.
> 
> 
> Thanks,
> 
> daniel voros
> 
>

Reply via email to