> On Aug. 15, 2018, 12:24 p.m., daniel voros wrote:
> > Hi Nguyen,
> >
> > Thanks for your contribution! Have you considered using
> > ReflectionToStringBuilder from commons-lang3? You could achieve similar
> > results by overriding toString() only in OraOopOracleDataChunk without
> > having to worry about future fields added to the classes:
> >
> > ```
> > @Override
> > public String toString() {
> > return ReflectionToStringBuilder.toString(this,
> > ToStringStyle.MULTI_LINE_STYLE);
> > }
> > ```
> >
> > If you decide to keep the current solution, I'd recommend replacing
> > `super.getId()` with `getId()` in the toString methods.
> >
> > Regards,
> > Daniel
Hi Daniel,
Thanks for your recommendation.
I decided to keep the currely solution because I prefer implementing methods
inside subclasses rather than inside the superclass.
Best,
Nguyen
- Nguyen
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68316/#review207321
-----------------------------------------------------------
On Aug. 14, 2018, 12:53 p.m., Nguyen Truong wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68316/
> -----------------------------------------------------------
>
> (Updated Aug. 14, 2018, 12:53 p.m.)
>
>
> Review request for Sqoop.
>
>
> Bugs: SQOOP-3362
> https://issues.apache.org/jira/browse/SQOOP-3362
>
>
> Repository: sqoop-trunk
>
>
> Description
> -------
>
> The method was currently returning the hash of data chunk object. I
> implemented the toString() methods inside the subclasses of
> OraOopOracleDataChunk.
>
>
> Diffs
> -----
>
> src/java/org/apache/sqoop/manager/oracle/OraOopDBInputSplit.java 948bdbb73
> src/java/org/apache/sqoop/manager/oracle/OraOopOracleDataChunk.java
> eb67fd2e4
> src/java/org/apache/sqoop/manager/oracle/OraOopOracleDataChunkExtent.java
> 20b39eea0
>
> src/java/org/apache/sqoop/manager/oracle/OraOopOracleDataChunkPartition.java
> 59889b82b
>
> src/test/org/apache/sqoop/manager/oracle/TestOraOopDBInputSplitGetDebugDetails.java
> PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/68316/diff/3/
>
>
> Testing
> -------
>
> No test case is added because the change has already covered.
>
>
> Thanks,
>
> Nguyen Truong
>
>
