> On Sept. 20, 2018, 10:29 a.m., Szabolcs Vasas wrote: > > src/test/org/apache/sqoop/s3/TestS3ExternalHiveTableTextImport.java > > Lines 112 (patched) > > <https://reviews.apache.org/r/68712/diff/2/?file=2090098#file2090098line112> > > > > This assert could be simplified if we introduce a convenience method to > > HiveServer2TestUtils, which would return the rows in CSV. For example: > > > > public List<String> loadCsvRowsFromTable(String tableName) { > > return loadRawRowsFromTable(tableName).stream() > > .map(list -> StringUtils.join(list, ",")) > > .collect(toList()); > > } > > > > If we have this method we can just use Assert.assertEquals to compare > > the 2 lists.
You are totally right, thanks for the suggestion! I have changed to a parameterized test case instead. - Boglarka ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68712/#review208794 ----------------------------------------------------------- On Sept. 24, 2018, 11:12 p.m., Boglarka Egyed wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/68712/ > ----------------------------------------------------------- > > (Updated Sept. 24, 2018, 11:12 p.m.) > > > Review request for Sqoop, daniel voros, Fero Szabo, and Szabolcs Vasas. > > > Bugs: SQOOP-3376 > https://issues.apache.org/jira/browse/SQOOP-3376 > > > Repository: sqoop-trunk > > > Description > ------- > > Testing the Text and Parquet imports into an external Hive table backed by S3. > > > Diffs > ----- > > src/test/org/apache/sqoop/s3/TestS3ExternalHiveTableImport.java > PRE-CREATION > src/test/org/apache/sqoop/testutil/HiveServer2TestUtil.java > 799370816cccda7578d7c64add6e283d3123e1c8 > src/test/org/apache/sqoop/testutil/S3TestUtils.java > 0e6ef5bf001797aa70a7ad50d261c6fd384222fe > > > Diff: https://reviews.apache.org/r/68712/diff/3/ > > > Testing > ------- > > ./gradlew test -Ds3.bucket.url=<bucket-url> > -Ds3.generator.command=<credential-generator-command> > > > Thanks, > > Boglarka Egyed > >
