----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69407/ -----------------------------------------------------------
(Updated Nov. 21, 2018, 3 p.m.) Review request for Sqoop, Boglarka Egyed and Szabolcs Vasas. Bugs: SQOOP-3405 https://issues.apache.org/jira/browse/SQOOP-3405 Repository: sqoop-trunk Description ------- Breaking up the parameterized test classes into a per database basis. Provides better readability, needed for proper test categorization (and thus, for travis integration). Diffs (updated) ----- src/test/org/apache/sqoop/importjob/DatabaseAdapterFactory.java PRE-CREATION src/test/org/apache/sqoop/importjob/NumericTypesImportTest.java af310cb src/test/org/apache/sqoop/importjob/SplitByImportTest.java 90b7cbb src/test/org/apache/sqoop/importjob/configuration/MSSQLServerImportJobTestConfiguration.java 4ad7def src/test/org/apache/sqoop/importjob/configuration/MySQLImportJobTestConfiguration.java fbcbdeb src/test/org/apache/sqoop/importjob/configuration/MysqlImportJobTestConfiguration.java PRE-CREATION src/test/org/apache/sqoop/importjob/configuration/SqlServerImportJobTestConfiguration.java PRE-CREATION src/test/org/apache/sqoop/importjob/numerictypes/MysqlNumericTypesImportTest.java PRE-CREATION src/test/org/apache/sqoop/importjob/numerictypes/NumericTypesImportTestBase.java PRE-CREATION src/test/org/apache/sqoop/importjob/numerictypes/OracleNumericTypesImportTest.java PRE-CREATION src/test/org/apache/sqoop/importjob/numerictypes/PostgresNumericTypesImportTest.java PRE-CREATION src/test/org/apache/sqoop/importjob/numerictypes/SqlServerNumericTypesImportTest.java PRE-CREATION src/test/org/apache/sqoop/importjob/splitby/MysqlSplitByImportTest.java PRE-CREATION src/test/org/apache/sqoop/importjob/splitby/OracleSplitByImportTest.java PRE-CREATION src/test/org/apache/sqoop/importjob/splitby/PostgresSplitByImportTest.java PRE-CREATION src/test/org/apache/sqoop/importjob/splitby/SplitByImportTestBase.java PRE-CREATION src/test/org/apache/sqoop/importjob/splitby/SqlServerSplitByImportTest.java PRE-CREATION src/test/org/apache/sqoop/testutil/adapter/MSSQLServerDatabaseAdapter.java 2256716 src/test/org/apache/sqoop/testutil/adapter/MySqlDatabaseAdapter.java ebd0146 src/test/org/apache/sqoop/testutil/adapter/MysqlDatabaseAdapter.java PRE-CREATION src/test/org/apache/sqoop/testutil/adapter/SqlServerDatabaseAdapter.java PRE-CREATION Diff: https://reviews.apache.org/r/69407/diff/6/ Changes: https://reviews.apache.org/r/69407/diff/5-6/ Testing ------- unit and 3rd party tests. Thanks, Fero Szabo