----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69430/#review210803 -----------------------------------------------------------
Ship it! Ship It! - Fero Szabo On Nov. 22, 2018, 1:37 p.m., Boglarka Egyed wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/69430/ > ----------------------------------------------------------- > > (Updated Nov. 22, 2018, 1:37 p.m.) > > > Review request for Sqoop, Fero Szabo and Szabolcs Vasas. > > > Bugs: SQOOP-3409 > https://issues.apache.org/jira/browse/SQOOP-3409 > > > Repository: sqoop-trunk > > > Description > ------- > > Temporary root directory clean up doesn't work as expected, many generated > temprootdirs are being kept in the used bucket after test runs. This was > caused as the target directory cleanup and name reset happened before the > temprootdir cleanup however the temprootdir name depends on the target dir > name in the tests. > > > Diffs > ----- > > src/test/org/apache/sqoop/testutil/S3TestUtils.java > 2fc606115196a7a2b6088be104e2a421888f8798 > > > Diff: https://reviews.apache.org/r/69430/diff/1/ > > > Testing > ------- > > ./gradlew s3Test -Ds3.bucket.url=<your-bucket-url> > -Ds3.generator.command=<your-credential-generator-command>, all the used > temprootdirs have been cleaned up > > > Thanks, > > Boglarka Egyed > >
