[
https://issues.apache.org/jira/browse/SQOOP-3396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16704038#comment-16704038
]
ASF GitHub Bot commented on SQOOP-3396:
---------------------------------------
Github user maugly24 commented on a diff in the pull request:
https://github.com/apache/sqoop/pull/60#discussion_r237698979
--- Diff:
src/test/org/apache/sqoop/importjob/configuration/MysqlImportJobTestConfiguration.java
---
@@ -65,4 +66,21 @@
public String toString() {
return getClass().getSimpleName();
}
+
+ @Override
+ public Object[] getExpectedResultsForHive() {
--- End diff --
Source of code duplication again!
I would move these expected values into a helper class or a super class
(choice is up to you).
> Add parquet numeric support for Parquet in Hive import
> ------------------------------------------------------
>
> Key: SQOOP-3396
> URL: https://issues.apache.org/jira/browse/SQOOP-3396
> Project: Sqoop
> Issue Type: Sub-task
> Reporter: Fero Szabo
> Assignee: Fero Szabo
> Priority: Major
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
