Github user fszabo2 commented on a diff in the pull request: https://github.com/apache/sqoop/pull/60#discussion_r239057294 --- Diff: src/test/org/apache/sqoop/hive/TestHiveTypesForAvroTypeMapping.java --- @@ -41,30 +44,49 @@ private final String hiveType; private final Schema schema; + private final SqoopOptions options; - @Parameters(name = "hiveType = {0}, schema = {1}") + @Parameters(name = "hiveType = {0}, schema = {1}, options = {2}") public static Iterable<? extends Object> parameters() { return Arrays.asList( - new Object[]{"BOOLEAN", Schema.create(Schema.Type.BOOLEAN)}, - new Object[]{"INT", Schema.create(Schema.Type.INT)}, - new Object[]{"BIGINT", Schema.create(Schema.Type.LONG)}, - new Object[]{"FLOAT", Schema.create(Schema.Type.FLOAT)}, - new Object[]{"DOUBLE", Schema.create(Schema.Type.DOUBLE)}, - new Object[]{"STRING", Schema.createEnum("ENUM", "doc", "namespce", new ArrayList<>())}, // Schema.Type.ENUM - new Object[]{"STRING", Schema.create(Schema.Type.STRING)}, - new Object[]{"BINARY", Schema.create(Schema.Type.BYTES)}, - new Object[]{"BINARY", Schema.createFixed("Fixed", "doc", "space", 1) } - //, new Object[]{"DECIMAL", Schema.create(Schema.Type.UNION).} + new Object[]{"BOOLEAN", Schema.create(Schema.Type.BOOLEAN), new SqoopOptions()}, --- End diff -- I've added a bunch of static imports (also for Schema.Type) so now the whole thing is a lot more readable.
---