Travis Vitek wrote:


Martin Sebor wrote:
[EMAIL PROTECTED] wrote:
@@ -35,6 +35,7 @@
#ifdef _MSC_VER
 #  include <climits>     // for INT_MAX
+#  include <crtdbg.h>    // for _CrtSetReportMode()
 #endif
#include <rw_new.h>
Should we do this in <rw_new.h> (or new.cpp, on the first call
to operator new or operator delete) instead?

Martin


Seems that we would want to do something like this in the test driver...

  _CrtSetReportMode (_CRT_WARN, _CRTDBG_MODE_FILE);
  _CrtSetReportFile (_CRT_WARN, _CRTDBG_FILE_STDERR);

  _CrtSetReportMode (_CRT_ERROR, _CRTDBG_MODE_FILE);
  _CrtSetReportFile (_CRT_ERROR, _CRTDBG_FILE_STDERR);

  _CrtSetReportMode (_CRT_ASSERT, _CRTDBG_MODE_FILE);
  _CrtSetReportFile (_CRT_ASSERT, _CRTDBG_FILE_STDERR);

That way all tests using the driver would dump failures to the console, much
like they would on a *nix system. Is there any reason to _not_ do this?

We're already doing exactly this in the Rogue Wave test driver
(which the stdcxx test driver links with in our nightly builds)
but not in our own. I agree we should.

Martin


Travis

Reply via email to