> -----Original Message----- > From: Martin Sebor [mailto:[EMAIL PROTECTED] On Behalf Of Martin Sebor > Sent: Monday, March 10, 2008 3:39 PM > To: dev@stdcxx.apache.org > Subject: Re: STDCXX-401 > > Thanks for the patch, Scott! I think this a start, but suspect > there are a few other places in the test suite that might need > to be changed as well (the locale tests?) >
The only function I saw that needed this change was rw_tmpnam()(implemented in file.cpp), I believe locale test uses rw_tmpnam to create the temporary file. > Let me take this opportunity to ask you to please review our > guidelines for Submitting Patches and the expected Patch Format: > > http://stdcxx.apache.org/bugs.html#patches > http://stdcxx.apache.org/bugs.html#patch_format > > Specifically, the string [PATCH] in the subject line is helpful > in identifying patches among other discussions on the list (and > in setting up mail filters for such things). Unless the patch is > entirely trivial, we also need some narrative to go with it. For > simple patches a Change Log entry usually does the job (see bullet > 3). For anything even moderately involved, a description of what > the patch actually does is recommended (bullet 1). > > Finally, while we don't have a style document for stdcxx (yet) we > do follow pretty consistent formatting style. To make integrating > your patches easier for us please take a look at nearby code and > try to follow the same style especially WRT braces and whitespace > usage. > > Martin > Sorry Martin, I follow the guidelines more closely. Since there are 2 more files with this patch, are subtasks needed?
