On 2015-04-02 18:40, Jim Jagielski wrote:
On Apr 2, 2015, at 12:39 PM, Jim Jagielski <[email protected]> wrote:
On Apr 2, 2015, at 9:51 AM, Daniel Gruno <[email protected]> wrote:
HI folks,
I made a couple of changes to the STV method today:
- Fixed an issue wherein if no one was 'lowest', STV would break
Can you point to the revision number for that? thx
I see http://svn.apache.org/r1670902, but you said you
fixed it (or maybe I'm misunderstanding what you mean
by fixed it and that STV "would break") :)
Yes, that revision fixes the error when it can't find a lowest scorer,
in which case 'which' never gets set and the comparison function breaks
because it expects 'which' to be a Candidate class. I ran some
simulations, which repeatedly broke when there was a tie between the two
bottom candidates, and this revision (r1670902) addressed that issue.
With regards,
Daniel.
