[ 
https://issues.apache.org/jira/browse/STORM-444?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14154159#comment-14154159
 ] 

ASF GitHub Bot commented on STORM-444:
--------------------------------------

Github user harshach commented on a diff in the pull request:

    https://github.com/apache/storm/pull/226#discussion_r18257239
  
    --- Diff: 
storm-core/src/jvm/backtype/storm/security/auth/hadoop/AutoHBase.java ---
    @@ -0,0 +1,163 @@
    +/**
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + * http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package backtype.storm.security.auth.hadoop;
    +
    +import backtype.storm.Config;
    +import org.slf4j.Logger;
    +import org.slf4j.LoggerFactory;
    +
    +import javax.security.auth.Subject;
    +import java.io.ByteArrayOutputStream;
    +import java.io.DataOutput;
    +import java.io.ObjectOutputStream;
    +import java.lang.reflect.Method;
    +import java.util.HashMap;
    +import java.util.Map;
    +
    +/**
    + * Automatically get hbase delegation tokens and push it to user's 
topology. The class
    + * assumes that hadoop/hbase configuration files are in your class path.
    + */
    +public class AutoHBase extends AbstractAutoHadoopPlugin {
    +    private static final Logger LOG = 
LoggerFactory.getLogger(AutoHBase.class);
    +
    +    public static final String HBASE_CREDENTIALS = "HBASE_CREDENTIALS";
    +
    +    @SuppressWarnings("unchecked")
    +    @Override
    +    protected byte[] getHadoopCredentials(Map conf) {
    +
    +        try {
    +            // What we want to do is following:
    --- End diff --
    
    nitpicking here but can we change this comment into a text rather than code 
:)


> (Security) Add AutoHDFS like credential fetching for HBase
> ----------------------------------------------------------
>
>                 Key: STORM-444
>                 URL: https://issues.apache.org/jira/browse/STORM-444
>             Project: Apache Storm
>          Issue Type: New Feature
>            Reporter: Robert Joseph Evans
>
> This is a lot like STORM-346, but should have support for HBase instead of 
> HDFS.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to