[ 
https://issues.apache.org/jira/browse/STORM-532?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14173598#comment-14173598
 ] 

ASF GitHub Bot commented on STORM-532:
--------------------------------------

Github user HeartSaVioR commented on a diff in the pull request:

    https://github.com/apache/storm/pull/293#discussion_r18947137
  
    --- Diff: storm-core/src/clj/backtype/storm/util.clj ---
    @@ -356,6 +356,10 @@
         (first split)
         ))
     
    + (defn exists-process?
    --- End diff --
    
    Windows users also use Storm, so I think OS specific code should be 
discouraged, or need to provide alternatives.


> Supervisor should restart worker immediately, if the worker process does not 
> exist any more 
> --------------------------------------------------------------------------------------------
>
>                 Key: STORM-532
>                 URL: https://issues.apache.org/jira/browse/STORM-532
>             Project: Apache Storm
>          Issue Type: Improvement
>    Affects Versions: 0.10.0
>            Reporter: caofangkun
>            Priority: Minor
>
> For now 
> if the worker process does not exist any more 
> Supervisor will have to wait a few seconds for worker heartbeart timeout and 
> restart worker .
> If supervisor knows the worker processid  and check if the process exists in 
> the sync-processes thread ,may need less time to restart worker.
> 1: record worker process id in the worker local heartbeart 
> 2: in supervisor  sync-processes ,get process id from worker local heartbeat 
> and check if the process exits 
> 3: if not restart it immediately



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to