[ 
https://issues.apache.org/jira/browse/STORM-549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14201340#comment-14201340
 ] 

Jungtaek Lim commented on STORM-549:
------------------------------------

(Warning: Need citation)

I'm newbie to Storm Project, but I can find usage from "setup-ticks!" in 
executor.clj.

{code}
(defn setup-ticks! [worker executor-data]
  (let [storm-conf (:storm-conf executor-data)
        tick-time-secs (storm-conf TOPOLOGY-TICK-TUPLE-FREQ-SECS)
        receive-queue (:receive-queue executor-data)
        context (:worker-context executor-data)]
    (when tick-time-secs
      (if (or (system-id? (:component-id executor-data))
              (and (not (storm-conf TOPOLOGY-ENABLE-MESSAGE-TIMEOUTS))
                   (= :spout (:type executor-data))))
        (log-message "Timeouts disabled for executor " (:component-id 
executor-data) ":" (:executor-id executor-data))
        (schedule-recurring
          (:user-timer worker)
          tick-time-secs
          tick-time-secs
          (fn []
            (disruptor/publish
              receive-queue
              [[nil (TupleImpl. context [tick-time-secs] 
Constants/SYSTEM_TASK_ID Constants/SYSTEM_TICK_STREAM_ID)]]
              )))))))
{code}

If worker is Spout and TOPOLOGY-ENABLE-MESSAGE-TIMEOUTS is disabled, it doesn't 
send tick tuple which means it's time to check tuples timeout.

tl;dr. It seems that it's working properly, though I've not tested yet.

> "topology.enable.message.timeouts" does nothing
> -----------------------------------------------
>
>                 Key: STORM-549
>                 URL: https://issues.apache.org/jira/browse/STORM-549
>             Project: Apache Storm
>          Issue Type: Bug
>    Affects Versions: 0.9.2-incubating, 0.9.1-incubating
>            Reporter: Sean T Allen
>
> The configuration option, added on 0.8.0 was never implemented:
> ➜  apache-storm-0.9.2-incubating ag "topology.enable.message.timeouts"
> conf/defaults.yaml
> 122:topology.enable.message.timeouts: true
> storm-core/src/jvm/backtype/storm/Config.java
> 512:    public static final String TOPOLOGY_ENABLE_MESSAGE_TIMEOUTS = 
> "topology.enable.message.timeouts";
> ➜  apache-storm-0.9.2-incubating ag TOPOLOGY_ENABLE_MESSAGE_TIMEOUTS
> storm-core/src/jvm/backtype/storm/Config.java
> 512:    public static final String TOPOLOGY_ENABLE_MESSAGE_TIMEOUTS = 
> "topology.enable.message.timeouts";
> 513:    public static final Object TOPOLOGY_ENABLE_MESSAGE_TIMEOUTS_SCHEMA = 
> Boolean.class;



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to