[
https://issues.apache.org/jira/browse/STORM-549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14203454#comment-14203454
]
ASF GitHub Bot commented on STORM-549:
--------------------------------------
GitHub user SeanTAllen opened a pull request:
https://github.com/apache/storm/pull/309
STORM-549: "topology.enable.message.timeouts" does nothing
The ability to turn off message timeouts doesn't work.
The value is a true/false value that is represented as
a Java Boolean. The check for the truthiness used the
clojure not function. The idea was, turn off message
timeouts if "topology.enable.message.timeouts" is not true.
Unfortunately this won't worth with clojure's definition of
truthiness as:
(not (Boolean. false))
evaluates to true.
This commit updates the logic to compare the Java Boolean
"topology.enable.message.timeouts" to false using the
= function which will work.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/SeanTAllen/storm master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/storm/pull/309.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #309
----
commit 0505d47471170861ad303dc530a8d8de4e730c10
Author: Sean T Allen <s...@monkeysnatchbanana.com>
Date: 2014-11-08T14:41:29Z
STORM-549: "topology.enable.message.timeouts" does nothing
The ability to turn off message timeouts doesn't work.
The value is a true/false value that is represented as
a Java Boolean. The check for the truthiness used the
clojure not function. The idea was, turn off message
timeouts if "topology.enable.message.timeouts" is not true.
Unfortunately this won't worth with clojure's definition of
truthiness as:
(not (Boolean. false))
evaluates to true.
This commit updates the logic to compare the Java Boolean
"topology.enable.message.timeouts" to false using the
= function which will work.
----
> "topology.enable.message.timeouts" does nothing
> -----------------------------------------------
>
> Key: STORM-549
> URL: https://issues.apache.org/jira/browse/STORM-549
> Project: Apache Storm
> Issue Type: Bug
> Affects Versions: 0.9.2-incubating, 0.9.1-incubating
> Reporter: Sean T Allen
> Fix For: 0.9.3-rc2
>
>
> The configuration option, added on 0.8.0 was never implemented:
> ➜ apache-storm-0.9.2-incubating ag "topology.enable.message.timeouts"
> conf/defaults.yaml
> 122:topology.enable.message.timeouts: true
> storm-core/src/jvm/backtype/storm/Config.java
> 512: public static final String TOPOLOGY_ENABLE_MESSAGE_TIMEOUTS =
> "topology.enable.message.timeouts";
> ➜ apache-storm-0.9.2-incubating ag TOPOLOGY_ENABLE_MESSAGE_TIMEOUTS
> storm-core/src/jvm/backtype/storm/Config.java
> 512: public static final String TOPOLOGY_ENABLE_MESSAGE_TIMEOUTS =
> "topology.enable.message.timeouts";
> 513: public static final Object TOPOLOGY_ENABLE_MESSAGE_TIMEOUTS_SCHEMA =
> Boolean.class;
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
