[
https://issues.apache.org/jira/browse/STORM-188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14216331#comment-14216331
]
ASF GitHub Bot commented on STORM-188:
--------------------------------------
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/120#discussion_r20513760
--- Diff: storm-core/src/jvm/backtype/storm/utils/Utils.java ---
@@ -122,36 +124,64 @@ public static void sleep(long millis) {
}
}
+ // Will try to locate the config file in class path first, then will
search local path
+ // For example, we can use temporary config path like this: storm jar
job.jar --config /tmp/xx.yaml
public static Map findAndReadConfigFile(String name, boolean
mustExist) {
+ InputStream in = null;
try {
- HashSet<URL> resources = new HashSet<URL>(findResources(name));
- if(resources.isEmpty()) {
- if(mustExist) throw new RuntimeException("Could not find
config file on classpath " + name);
- else return new HashMap();
- }
- if(resources.size() > 1) {
- throw new RuntimeException("Found multiple " + name + "
resources. You're probably bundling the Storm jars with your topology jar. "
- + resources);
- }
- URL resource = resources.iterator().next();
- Yaml yaml = new Yaml(new SafeConstructor());
- Map ret = null;
- InputStream input = resource.openStream();
- try {
- ret = (Map) yaml.load(new InputStreamReader(input));
- } finally {
- input.close();
+ in = getConfigFileInputStream(name);
+ if (null != in) {
+ Yaml yaml = new Yaml();
--- End diff --
Can we change this to ```Yaml yaml = new Yaml(new SafeConstructor());```
> Allow user to specifiy full configuration path when running storm command
> -------------------------------------------------------------------------
>
> Key: STORM-188
> URL: https://issues.apache.org/jira/browse/STORM-188
> Project: Apache Storm
> Issue Type: Bug
> Reporter: Sean Zhong
> Priority: Minor
> Attachments: search_local_path_for_config.patch, storm-188.patch
>
> Original Estimate: 168h
> Remaining Estimate: 168h
>
> Currently, storm will only look up configuration path in java classpath. We
> should also allow user to specify full configuration path. This is very
> important for a shared cluster environment, like YARN. Multiple storm cluster
> may runs with different configuration, but share same binary folder.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
