[
https://issues.apache.org/jira/browse/STORM-584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14235564#comment-14235564
]
ASF GitHub Bot commented on STORM-584:
--------------------------------------
Github user revans2 commented on the pull request:
https://github.com/apache/storm/pull/337#issuecomment-65799993
+1 this change itself looks good, but there are a number of issues with the
metrics.log file. I filed STORM-584 to address them.
> LoggingMetricsConsumer metrics.log file is shared by multiple topologies.
> -------------------------------------------------------------------------
>
> Key: STORM-584
> URL: https://issues.apache.org/jira/browse/STORM-584
> Project: Apache Storm
> Issue Type: Bug
> Affects Versions: 0.10.0
> Reporter: Robert Joseph Evans
> Priority: Critical
>
> The current cluster.xml file has special configuration for the
> LoggingMetricsConsumer to place it in a metrics.log file. There are several
> issues with this.
> The worker, where the LoggingMetricsConsumer is run, is configured using
> worker.xml and not cluster.xml.
> The metrics.log file is shared by all workers running on the same node. So
> if by chance we have LoggingMetricsConsumer instances running at the same
> time, the resulting log file could have a number of issues, including data
> corruption.
> This becomes much worse under security where only the first
> LoggingMetricsConsumer to run on the node will own the file, and all others
> will fail to log metrics.
> Also there is no way to access metrics.log through the ui now.
> Ideally the metrics.log file will follow a pattern similar to the worker log
> file, and have the topology name and the worker port a part of it. We also
> would want to update the logviewer daemon to allow serving up these files and
> deleting them after a specific period of time. The it would be awesome if
> the UI could detect that a logging metrics consumer is installed, and provide
> links to the metrics.log file as well.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
